You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/23 06:21:17 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #127: chore: prometheus metrics handler
tokers opened a new pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #127: chore: prometheus metrics handler
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127#discussion_r547927455
##########
File path: pkg/api/router/router.go
##########
@@ -34,7 +35,16 @@ func healthz(c *gin.Context) {
return
}
+func mountMetrics(r *gin.Engine) {
+ r.GET("/metrics", metrics)
Review comment:
It is the API of apisix ingress controller itself, users cannot add apis to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis merged pull request #127: chore: prometheus metrics handler
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #127: chore: prometheus metrics handler
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127#issuecomment-749961833
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=h1) Report
> Merging [#127](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=desc) (c3ac5b3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/87d59885f2c5f884b16799ca6ffb35ef1bc4f99b?el=desc) (87d5988) will **increase** coverage by `0.03%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 61.19% 61.22% +0.03%
==========================================
Files 16 16
Lines 536 539 +3
==========================================
+ Hits 328 330 +2
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <66.66%> (-5.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=footer). Last update [87d5988...c3ac5b3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #127: chore: prometheus metrics handler
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127#discussion_r547780867
##########
File path: pkg/api/router/router.go
##########
@@ -34,7 +35,16 @@ func healthz(c *gin.Context) {
return
}
+func mountMetrics(r *gin.Engine) {
+ r.GET("/metrics", metrics)
Review comment:
Will it conflict with the user's existing API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #127: chore: prometheus metrics handler
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127#discussion_r548008555
##########
File path: pkg/api/router/router.go
##########
@@ -34,7 +35,16 @@ func healthz(c *gin.Context) {
return
}
+func mountMetrics(r *gin.Engine) {
+ r.GET("/metrics", metrics)
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org