You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by lazyval <gi...@git.apache.org> on 2015/08/07 17:09:04 UTC
[GitHub] kafka pull request: Reducing code duplication in DefaultEventHandl...
GitHub user lazyval opened a pull request:
https://github.com/apache/kafka/pull/125
Reducing code duplication in DefaultEventHandler
No functionality was changed -- just removed code duplication & [get advantage of case class copy method](http://stackoverflow.com/questions/7249396/how-to-clone-a-case-class-instance-and-change-just-one-field-in-scala).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lazyval/kafka minor-readability-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit bfb253b28be5a8367533aa36712d9a0bcc443109
Author: Kostya Golikov <jo...@gmail.com>
Date: 2015-08-07T15:03:02Z
Reducing code duplication and emphasizing pieces that actually changing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request: Reducing code duplication in DefaultEventHandl...
Posted by lazyval <gi...@git.apache.org>.
GitHub user lazyval reopened a pull request:
https://github.com/apache/kafka/pull/125
Reducing code duplication in DefaultEventHandler
No functionality was changed -- just removed code duplication & [get advantage of case class copy method](http://stackoverflow.com/questions/7249396/how-to-clone-a-case-class-instance-and-change-just-one-field-in-scala).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lazyval/kafka minor-readability-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit bfb253b28be5a8367533aa36712d9a0bcc443109
Author: Kostya Golikov <jo...@gmail.com>
Date: 2015-08-07T15:03:02Z
Reducing code duplication and emphasizing pieces that actually changing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request: Reducing code duplication in DefaultEventHandl...
Posted by lazyval <gi...@git.apache.org>.
Github user lazyval closed the pull request at:
https://github.com/apache/kafka/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #125: Reducing code duplication in DefaultEventHandler
Posted by pono <gi...@git.apache.org>.
Github user pono closed the pull request at:
https://github.com/apache/kafka/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---