You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/03/27 08:43:35 UTC
[PR] Centralize dependency versions in root pom.xml [pinot]
xiangfu0 opened a new pull request, #17999:
URL: https://github.com/apache/pinot/pull/17999
## Summary
- Move all dependency and plugin versions from module pom.xml files to the root pom.xml `dependencyManagement`/`pluginManagement` sections
- Add Spark (core, sql, launcher), protobuf-dynamic, localstack-utils to root `dependencyManagement`
- Add build-helper-maven-plugin to root `pluginManagement`
- Remove redundant `<version>` tags from 10 module pom.xml files (pinot-arrow, pinot-kafka-3.0, pinot-integration-tests, pinot-batch-ingestion-spark-3, pinot-spark-3-connector, pinot-tools, pinot-protobuf, pinot-kinesis, pinot-controller, pinot-timeseries-m3ql)
## Documented Exceptions
Three version overrides must remain in modules (each has an XML comment explaining why):
1. **pinot-kafka-4.0**: `kafka-clients` uses `${kafka4.version}` — targets Kafka 4.x (different major version from root-managed Kafka 3.x)
2. **pinot-confluent-json**: `scala-library` uses `${scala-2.13.version}` — Confluent's kafka-json-schema-serializer requires Scala 2.13 (rest of project uses 2.12)
3. **pinot-common**: `fmpp` inside maven-antrun-plugin's `<dependencies>` — plugin dependencies cannot use `dependencyManagement` (already centralized via `${fmpp.version}` property)
## Out of Scope
- `contrib/pinot-druid-benchmark/pom.xml` — standalone project with different groupId, not a Pinot module
## Test plan
- [ ] Verified all external dependencies resolve correctly via `mvn help:effective-pom`
- [ ] Verified `mvn validate` passes on all modules
- [ ] CI build passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Centralize dependency versions in root pom.xml [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #17999:
URL: https://github.com/apache/pinot/pull/17999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Centralize dependency versions in root pom.xml [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17999:
URL: https://github.com/apache/pinot/pull/17999#issuecomment-4141322164
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17999?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.45%. Comparing base ([`cd3e850`](https://app.codecov.io/gh/apache/pinot/commit/cd3e850ca93ad0b54de53feec5865584a785dc4d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9758abb`](https://app.codecov.io/gh/apache/pinot/commit/9758abb72b91e377a70f06979b506893ccd3d4ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (cd3e850) and HEAD (9758abb). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (cd3e850) | HEAD (9758abb) |
>|------|------|------|
>|java-21|5|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|10|1|
>|java-11|5|0|
>|unittests2|2|0|
>|integration|6|0|
>|integration2|2|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17999 +/- ##
============================================
- Coverage 63.31% 55.45% -7.86%
+ Complexity 1541 745 -796
============================================
Files 3200 2502 -698
Lines 194102 143045 -51057
Branches 29892 22959 -6933
============================================
- Hits 122898 79332 -43566
+ Misses 61552 56956 -4596
+ Partials 9652 6757 -2895
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.45% <ø> (-7.83%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.45% <ø> (-7.86%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.45% <ø> (-7.86%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.45% <ø> (-0.03%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17999/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17999?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org