cvs commit: incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx NoSuchOperationError.java ProxyMethodInterceptor.java

[jb...@apache.org]

jboynes     2004/01/23 08:43:39

  Modified:    modules/kernel/src/java/org/apache/geronimo/gbean/jmx
                        ProxyMethodInterceptor.java
  Added:       modules/kernel/src/java/org/apache/geronimo/gbean/jmx
                        NoSuchOperationError.java
  Log:
  Throw an Error rather than NullPointer if there is nothing to invoke
  
  Revision  Changes    Path
  1.4       +3 -3      incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/ProxyMethodInterceptor.java
  
  Index: ProxyMethodInterceptor.java
  ===================================================================
  RCS file: /home/cvs/incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/ProxyMethodInterceptor.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ProxyMethodInterceptor.java	19 Jan 2004 06:33:24 -0000	1.3
  +++ ProxyMethodInterceptor.java	23 Jan 2004 16:43:39 -0000	1.4
  @@ -156,9 +156,9 @@
           }
           InvokeMBean invoker = methodTable[proxy.getSuperIndex()];
           if (invoker == null) {
  -            System.out.println("NO INVOKER FOR ");
  +            throw new NoSuchOperationError("No implementation method for "+method);
           }
  -        return methodTable[proxy.getSuperIndex()].invoke(server, objectName, args);
  +        return invoker.invoke(server, objectName, args);
       }
   
       public static InvokeMBean[] createMethodTable(MBeanServer server, ObjectName objectName, Class proxyType) {
  
  
  
  1.1                  incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/NoSuchOperationError.java
  
  Index: NoSuchOperationError.java
  ===================================================================
  /* ====================================================================
   * The Apache Software License, Version 1.1
   *
   * Copyright (c) 2003 The Apache Software Foundation.  All rights
   * reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *    notice, this list of conditions and the following disclaimer.
   *
   * 2. Redistributions in binary form must reproduce the above copyright
   *    notice, this list of conditions and the following disclaimer in
   *    the documentation and/or other materials provided with the
   *    distribution.
   *
   * 3. The end-user documentation included with the redistribution,
   *    if any, must include the following acknowledgment:
   *       "This product includes software developed by the
   *        Apache Software Foundation (http://www.apache.org/)."
   *    Alternately, this acknowledgment may appear in the software itself,
   *    if and wherever such third-party acknowledgments normally appear.
   *
   * 4. The names "Apache" and "Apache Software Foundation" and
   *    "Apache Geronimo" must not be used to endorse or promote products
   *    derived from this software without prior written permission. For
   *    written permission, please contact apache@apache.org.
   *
   * 5. Products derived from this software may not be called "Apache",
   *    "Apache Geronimo", nor may "Apache" appear in their name, without
   *    prior written permission of the Apache Software Foundation.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
   * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
   * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
   * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
   * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
   * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
   * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
   * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   * SUCH DAMAGE.
   * ====================================================================
   *
   * This software consists of voluntary contributions made by many
   * individuals on behalf of the Apache Software Foundation.  For more
   * information on the Apache Software Foundation, please see
   * <http://www.apache.org/>.
   *
   * ====================================================================
   */
  package org.apache.geronimo.gbean.jmx;
  
  import java.lang.reflect.Method;
  
  /**
   * 
   * 
   * @version $Revision: 1.1 $ $Date: 2004/01/23 16:43:39 $
   */
  public class NoSuchOperationError extends Error {
      public NoSuchOperationError(String message) {
          super(message);
      }
  }