[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`

[GitBox <gi...@apache.org>]

ChristopherSchultz commented on a change in pull request #232: Fix handling of query parameters with no value, like `?foo`
URL: https://github.com/apache/tomcat/pull/232#discussion_r365254773
 
 

 ##########
 File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java
 ##########
 @@ -354,4 +364,11 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp)
             }
         }
     }
+
+    private static boolean objectsEqual(String object1, String object2) {
 
 Review comment:
   I agree that `getParameter` should remain: a parameter present with no value should return `""` and not `null`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org