[GitHub] [phoenix] dbwong commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution

[GitBox <gi...@apache.org>]

dbwong commented on a change in pull request #726: Phoenix-5760 Pherf Support Sequential Datatypes for INTEGER type fields and have fixed row distribution
URL: https://github.com/apache/phoenix/pull/726#discussion_r389898550
 
 

 ##########
 File path: phoenix-pherf/src/test/java/org/apache/phoenix/pherf/RuleGeneratorTest.java
 ##########
 @@ -175,7 +175,26 @@ public void testSequentialDataSequence() throws Exception {
         Column targetColumn = null;
         for (Column column : model.getDataMappingColumns()) {
             DataSequence sequence = column.getDataSequence();
-            if (sequence == DataSequence.SEQUENTIAL) {
+            if (!DataTypeMapping.INTEGER.equals(column.getType()) && sequence == DataSequence.SEQUENTIAL) {
+                targetColumn = column;
+                break;
+            }
+        }
+        assertNotNull("Could not find a DataSequence.SEQENTIAL rule.", targetColumn);
+        assertMultiThreadedIncrementValue(targetColumn, rulesApplier);
+    }
+
+    @Test
+    public void :testSequentialIntegerDataSequence() throws Exception {
 
 Review comment:
   Think this was accidental after realizing i had another commit on this branch during cleanup.  I'll fix and submit hadoopQA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services