You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/09/07 00:43:49 UTC

[Impala-ASF-CR] IMPALA-11226: Add script to simplify resolving minidumps

Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18918

to look at the new patch set (#2).

Change subject: IMPALA-11226: Add script to simplify resolving minidumps
......................................................................

IMPALA-11226: Add script to simplify resolving minidumps

This adds the resolve_minidumps.py script to
simplify resolving minidumps under ideal circumstances.
This is designed to handle cases where the binary
and libraries are in identical locations to when
the minidump was created. This is true for developer
environments and at the end of Jenkins jobs.

This uses Breakpad's minidump_dump utility to get a
list of the binaries/libraries that the minidump
references. It uses that list to dump all the
symbols to a temporary directory. Then it uses
the symbols to resolve the minidump.

Since it is dumping symbols for all referenced
libraries, it resolves symbols to the maximum
extent possible.

This adds a step to bin/jenkins/finalize.sh to use
this new script to resolve minidumps. The old method
can be removed in a subsequent change.

Testing:
 - Ran locally on a minidump generated by sending
   SIGUSR1 to local impalad
 - Tested with a Centos 7 job using Python 3.6
   and verified the minidump output

Change-Id: I0f8fdcb8ca89d0904dc8ec69337e3d5dfdd54adf
---
M bin/jenkins/finalize.sh
A bin/resolve_minidumps.py
2 files changed, 333 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/18918/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f8fdcb8ca89d0904dc8ec69337e3d5dfdd54adf
Gerrit-Change-Number: 18918
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>