You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Lyon Chen <ly...@gmail.com> on 2014/09/30 19:52:26 UTC

Anyone to review patches to remove duplicate reference to libCordova in cordova-ios?

Hi

I have a pull request (https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894) for issue (https://issues.apache.org/jira/browse/CB-7627). Basically it is about 2 references to the same libCordova.a file, one as add in commit fe397173 as force_load, the other one is add in commit ec2d51dd as a framework. And this causes problem when Jenkins is used to build and symbolic links is used in workspace, because Jenkins has a bug/feature that always dereference symbolic links to actual files.

The force_load situation is also talked about in http://stackoverflow.com/questions/4787279/xcode-get-force-load-to-work-with-relative-paths, which mentioned now “-ObjC” is good enough for Xcode 4 and up.

So can someone take the time to have a look at my pull request (https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894) to see whether it makes sense and can be merged?

Thanks
Lyon

Re: Anyone to review patches to remove duplicate reference to libCordova in cordova-ios?

Posted by Lyon Chen <ly...@gmail.com>.

Thanks, Shazron!

On Sep 30, 2014, at 1:56 PM, Shazron <sh...@gmail.com> wrote:

> Yes, it will be looked at. Unless someone else wants to take this on, I am
> the guy. Other pressing issues related to iOS 8 have been my focus.
> 
> On Tue, Sep 30, 2014 at 10:52 AM, Lyon Chen <ly...@gmail.com> wrote:
> 
>> Hi
>> 
>> I have a pull request (
>> https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894) for
>> issue (https://issues.apache.org/jira/browse/CB-7627). Basically it is
>> about 2 references to the same libCordova.a file, one as add in commit
>> fe397173 as force_load, the other one is add in commit ec2d51dd as a
>> framework. And this causes problem when Jenkins is used to build and
>> symbolic links is used in workspace, because Jenkins has a bug/feature that
>> always dereference symbolic links to actual files.
>> 
>> The force_load situation is also talked about in
>> http://stackoverflow.com/questions/4787279/xcode-get-force-load-to-work-with-relative-paths,
>> which mentioned now “-ObjC” is good enough for Xcode 4 and up.
>> 
>> So can someone take the time to have a look at my pull request (
>> https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894) to
>> see whether it makes sense and can be merged?
>> 
>> Thanks
>> Lyon

Re: Anyone to review patches to remove duplicate reference to libCordova in cordova-ios?

Posted by Shazron <sh...@gmail.com>.

Yes, it will be looked at. Unless someone else wants to take this on, I am
the guy. Other pressing issues related to iOS 8 have been my focus.

On Tue, Sep 30, 2014 at 10:52 AM, Lyon Chen <ly...@gmail.com> wrote:

> Hi
>
> I have a pull request (
> https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894) for
> issue (https://issues.apache.org/jira/browse/CB-7627). Basically it is
> about 2 references to the same libCordova.a file, one as add in commit
> fe397173 as force_load, the other one is add in commit ec2d51dd as a
> framework. And this causes problem when Jenkins is used to build and
> symbolic links is used in workspace, because Jenkins has a bug/feature that
> always dereference symbolic links to actual files.
>
> The force_load situation is also talked about in
> http://stackoverflow.com/questions/4787279/xcode-get-force-load-to-work-with-relative-paths,
> which mentioned now “-ObjC” is good enough for Xcode 4 and up.
>
> So can someone take the time to have a look at my pull request (
> https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894) to
> see whether it makes sense and can be merged?
>
> Thanks
> Lyon