You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2010/10/15 19:32:33 UTC

[jira] Created: (WICKET-3109) Using PopupSettings creates page maps early

Using PopupSettings creates page maps early
-------------------------------------------

                 Key: WICKET-3109
                 URL: https://issues.apache.org/jira/browse/WICKET-3109
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.12
            Reporter: Jeremy Thomerson
            Assignee: Jeremy Thomerson
            Priority: Minor


See WICKET-3108 for a description of the background (and a quickstart to demonstrate)

The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map.  The page map shouldn't be created until someone actually clicks the link, though.  The page map name will need to go in the URL, but the page map can be lazy-created.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-3109) Using PopupSettings creates page maps early

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/WICKET-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921458#action_12921458 ] 

Igor Vaynberg commented on WICKET-3109:
---------------------------------------

its not that popupsettings creates it, its that other components such as link call getpagemap on it. we should add getpagemapname() to popupsettings and refactor those components to use that instead since the only reason they call getpagemap is to get the name.

> Using PopupSettings creates page maps early
> -------------------------------------------
>
>                 Key: WICKET-3109
>                 URL: https://issues.apache.org/jira/browse/WICKET-3109
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.12
>            Reporter: Jeremy Thomerson
>            Assignee: Jeremy Thomerson
>            Priority: Minor
>
> See WICKET-3108 for a description of the background (and a quickstart to demonstrate)
> The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map.  The page map shouldn't be created until someone actually clicks the link, though.  The page map name will need to go in the URL, but the page map can be lazy-created.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.