You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/11 16:47:11 UTC

[GitHub] [beam] mxm commented on a change in pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

mxm commented on a change in pull request #12481:
URL: https://github.com/apache/beam/pull/12481#discussion_r467556781



##########
File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -1452,12 +1446,12 @@ public void populateDisplayData(DisplayData.Builder builder) {
       public static class Configuration {
 
         // All byte arrays are UTF-8 encoded strings
-        private Iterable<KV<String, String>> producerConfig;
+        private Map<String, String> producerConfig;
         private String topic;
         private String keySerializer;
         private String valueSerializer;

Review comment:
       Comment should be updated (no byte arrays anymore).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org