You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/03 00:55:00 UTC
[jira] [Commented] (SAMZA-1542) migrate config classes in
samza-core to use composition over inherence
[ https://issues.apache.org/jira/browse/SAMZA-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308939#comment-16308939 ]
ASF GitHub Bot commented on SAMZA-1542:
---------------------------------------
GitHub user fredji97 opened a pull request:
https://github.com/apache/samza/pull/398
SAMZA-1542 refactor config classes in samza-core java to hide non-necessary interfaces
With previous inheritance, it exposed everything from Config class, which is a bad practice and is error prone. We are refactoring it to use composition over inheritance make it more robust.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fredji97/samza samzaCoreJavaConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #398
----
commit 34dd7f40f044b7c219e402dbc4575579d0c42643
Author: Fred Ji <ha...@...>
Date: 2018-01-03T00:51:47Z
SAMZA-1542 refactor config classes in samza-core java to hide non-necessary interfaces
----
> migrate config classes in samza-core to use composition over inherence
> ----------------------------------------------------------------------
>
> Key: SAMZA-1542
> URL: https://issues.apache.org/jira/browse/SAMZA-1542
> Project: Samza
> Issue Type: Improvement
> Reporter: Fred Ji
> Assignee: Fred Ji
> Fix For: 0.15.0
>
>
> This is one of the child tasks from https://issues.apache.org/jira/browse/SAMZA-1160
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)