[GitHub] flink pull request #4771: [hotfix] [hbase] Set root log level to OFF for fli...

[fhueske <gi...@git.apache.org>]

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4771

    [hotfix] [hbase] Set root log level to OFF for flink-hbase tests.

    ## What is the purpose of the change
    
    Fix `flink-hbase` tests that fail on local builds and pass on Travis.
    
    ## Brief change log
    
    * Set root log level of `flink-hbase` to `OFF`
    * Log level is changed due to a buggy Calcite check that causes a NPE.
    * The check is only performed if log level DEBUG is enabled.
    
    ## Verifying this change
    
    * Tests on `flink-hbase` pass.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink hbaseTests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4771
    
----
commit 937b2a2028e8a30b7b91c9d03b46fb949f1c4fb8
Author: Fabian Hueske <fh...@apache.org>
Date:   2017-10-04T11:01:22Z

    [hotfix] [hbase] Set root log level to OFF for flink-hbase tests.
    
    Log level is changed due to a buggy Calcite check that causes a NPE.
    The check is only performed if log level DEBUG is enabled.

----


---

[GitHub] flink pull request #4771: [hotfix] [hbase] Set root log level to OFF for fli...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4771


---

[GitHub] flink issue #4771: [hotfix] [hbase] Set root log level to OFF for flink-hbas...

[zentol <gi...@git.apache.org>]

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4771
  
    maybe add a comment to the config file to not set this to debug, otherwise +1.


---

[GitHub] flink issue #4771: [hotfix] [hbase] Set root log level to OFF for flink-hbas...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4771
  
    btw. Calcite fixed the underlying issue in version 1.14 which was release a few days ago.


---

[GitHub] flink issue #4771: [hotfix] [hbase] Set root log level to OFF for flink-hbas...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4771
  
    Will address Zentol's comment and merge. This is blocking me...


---