You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2026/10/16 15:14:43 UTC
[PR] fix(datasets): don't call physical datasets "virtual" in sync columns toast [superset]
sfirke opened a new pull request, #45376:
URL: https://github.com/apache/superset/pull/45376
### SUMMARY
After **Edit dataset → Sync columns from source**, the toast reports added, modified,
or removed columns using the phrase "the virtual dataset", e.g. *"Added 1 new column
to the virtual dataset"*. That wording appears for every dataset, including physical
ones backed by a table or a database view, so it describes the dataset incorrectly.
The strings come from `updateColumns()` in
`superset-frontend/src/components/Datasource/utils/index.ts`. They were written for
the virtual-dataset SQL sync added in #30903. That helper is also called by
`DatasourceEditor`'s `syncMetadata()`, which backs the Sync button for physical and
virtual datasets alike, and it isn't told the dataset type. Before #30903 the
messages were neutral (`Modified columns: %s`).
This PR changes the six strings to neutral wording ("…to the dataset", "…in the
dataset", "…from the dataset"). I chose that over passing the dataset type through
and picking between virtual and physical wording, because the qualifier tells the
user nothing they need and would double the number of strings to translate.
**Translations.** Each catalog's existing translation is kept, with the word for
"virtual" removed. Where removing it changed the grammar, the sentence was adjusted:
Czech and Slovak prepositions (`ve`→`v`, `z`→`ze`/`zo`) and capitalization at the
start of the Finnish and Turkish sentences. These are machine edits, so every changed
entry is marked `#, fuzzy` for native-speaker review. Fuzzy entries are still served
in the UI. The `msgid` lines in `messages.pot` and in every `.po` were edited in
place, as in #45276. Running `babel_update.sh` was avoided because it pulls
thousands of unrelated pending strings into every catalog.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Text-only change to a success toast:
- Before: `Added 1 new column to the virtual dataset`
- After: `Added 1 new column to the dataset`
The same applies to the "Modified…" and "Removed…" variants and their plurals.
### TESTING INSTRUCTIONS
1. Add a column to a table or database view that backs a **physical** dataset.
2. In Superset, open **Edit dataset → Columns → Sync columns from source**.
3. The toast reads "Added 1 new column to the dataset" (no "virtual").
Automated:
- `npm run test -- src/components/Datasource/utils`
- `python scripts/translations/check_pot_drift.py`: passes
- `python scripts/translations/check_translation_regression.py --compare <baseline>`: passes, no regressions
- `npm run build-translation`: passes
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Related: #33733 fixed a raw `%s` in this same toast on a physical table but kept the
"virtual" wording.
---
🤖 _Drafted by Claude Code, reviewed and approved by @sfirke._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): don't call physical datasets "virtual" in sync columns toast [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45376:
URL: https://github.com/apache/superset/pull/45376#issuecomment-6219058317
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45376?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.91%. Comparing base ([`ad63b3e`](https://app.codecov.io/gh/apache/superset/commit/ad63b3eb7aba0e9410756c48a1ef6c448c254ecb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f7e1a4a`](https://app.codecov.io/gh/apache/superset/commit/f7e1a4a791a490ad56046de2123ca1236414687e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (ad63b3e) and HEAD (f7e1a4a). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (ad63b3e) | HEAD (f7e1a4a) |
>|------|------|------|
>|python|7|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45376 +/- ##
===========================================
- Coverage 83.49% 64.91% -18.59%
===========================================
Files 3047 3047
Lines 199516 199516
Branches 46552 46552
===========================================
- Hits 166589 129508 -37081
- Misses 29701 67080 +37379
+ Partials 3226 2928 -298
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.97% <ø> (ø)` | |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.23% <ø> (+0.01%)` | :arrow_up: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.72% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.80% <ø> (-34.21%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.69% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/45376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45376?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): don't call physical datasets "virtual" in sync columns toast [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #45376:
URL: https://github.com/apache/superset/pull/45376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(datasets): don't call physical datasets "virtual" in sync columns toast [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45376:
URL: https://github.com/apache/superset/pull/45376#issuecomment-6218820448
## CodeAnt PR Risk: Medium Risk
- The PR needs attention before merging because the updated toast messages are marked fuzzy in many translation catalogs.
- Fuzzy translations are not used by gettext, so users of those locales may see English for column-change notifications.
**Assessed commit:** `f7e1a4a791a4`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org