You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/23 08:04:54 UTC

[GitHub] [rocketmq] 6U-U9 opened a new pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

6U-U9 opened a new pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024


   ## What is the purpose of the change
   Constant charset defined by String (for example, "UTF-8") can be replaced with the predefined StandardCharsets.UTF_8 code.
   The code after the fix may work faster, because the charset lookup becomes unnecessary.
   
   ## Brief changelog
   Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#issuecomment-1082772521


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4024](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be4de18) into [develop](https://codecov.io/gh/apache/rocketmq/commit/4574d59f4b8d28888576293db6c019a1d2c37adb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4574d59) will **decrease** coverage by `0.00%`.
   > The diff coverage is `88.88%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4024      +/-   ##
   =============================================
   - Coverage      47.90%   47.90%   -0.01%     
   - Complexity      5001     5002       +1     
   =============================================
     Files            633      633              
     Lines          42523    42523              
     Branches        5573     5573              
   =============================================
   - Hits           20371    20369       -2     
   - Misses         19654    19660       +6     
   + Partials        2498     2494       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/rocketmq/common/MixAll.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vTWl4QWxsLmphdmE=) | `44.44% <0.00%> (ø)` | |
   | [...java/org/apache/rocketmq/acl/common/AclSigner.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL0FjbFNpZ25lci5qYXZh) | `81.48% <100.00%> (ø)` | |
   | [...apache/rocketmq/acl/common/SessionCredentials.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL1Nlc3Npb25DcmVkZW50aWFscy5qYXZh) | `56.94% <100.00%> (ø)` | |
   | [...er/transaction/queue/TransactionalMessageUtil.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vcXVldWUvVHJhbnNhY3Rpb25hbE1lc3NhZ2VVdGlsLmphdmE=) | `80.00% <100.00%> (ø)` | |
   | [...apache/rocketmq/common/message/MessageDecoder.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRGVjb2Rlci5qYXZh) | `77.65% <100.00%> (ø)` | |
   | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `62.63% <100.00%> (ø)` | |
   | [...cketmq/remoting/protocol/RemotingSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlbW90aW5nU2VyaWFsaXphYmxlLmphdmE=) | `62.50% <100.00%> (ø)` | |
   | [...cketmq/remoting/protocol/RocketMQSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JvY2tldE1RU2VyaWFsaXphYmxlLmphdmE=) | `86.45% <100.00%> (ø)` | |
   | [...etmq/tools/command/message/SendMessageCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWVzc2FnZS9TZW5kTWVzc2FnZUNvbW1hbmQuamF2YQ==) | `74.32% <100.00%> (ø)` | |
   | [...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==) | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4574d59...be4de18](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#issuecomment-1082770004


   
   [![Coverage Status](https://coveralls.io/builds/47818477/badge)](https://coveralls.io/builds/47818477)
   
   Coverage decreased (-0.01%) to 51.93% when pulling **be4de18eb0593b2ee93b487786a8a8adcb822eb4 on 6U-U9:develop** into **4574d59f4b8d28888576293db6c019a1d2c37adb on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] 6U-U9 commented on a change in pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
6U-U9 commented on a change in pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#discussion_r838442453



##########
File path: example/src/main/java/org/apache/rocketmq/example/openmessaging/SimpleProducer.java
##########
@@ -40,15 +39,15 @@ public static void main(String[] args) {
         System.out.printf("Producer startup OK%n");
 
         {
-            Message message = producer.createBytesMessage("OMS_HELLO_TOPIC", "OMS_HELLO_BODY".getBytes(Charset.forName("UTF-8")));

Review comment:
       I don't think it's necessary to specify the encode charset for message body.
   As long as one encode and decode the message with the same charset, he shall get the correct message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#issuecomment-1082772521


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4024](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be4de18) into [develop](https://codecov.io/gh/apache/rocketmq/commit/4574d59f4b8d28888576293db6c019a1d2c37adb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4574d59) will **decrease** coverage by `0.00%`.
   > The diff coverage is `88.88%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4024      +/-   ##
   =============================================
   - Coverage      47.90%   47.90%   -0.01%     
   - Complexity      5001     5002       +1     
   =============================================
     Files            633      633              
     Lines          42523    42523              
     Branches        5573     5573              
   =============================================
   - Hits           20371    20369       -2     
   - Misses         19654    19660       +6     
   + Partials        2498     2494       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/rocketmq/common/MixAll.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vTWl4QWxsLmphdmE=) | `44.44% <0.00%> (ø)` | |
   | [...java/org/apache/rocketmq/acl/common/AclSigner.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL0FjbFNpZ25lci5qYXZh) | `81.48% <100.00%> (ø)` | |
   | [...apache/rocketmq/acl/common/SessionCredentials.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL1Nlc3Npb25DcmVkZW50aWFscy5qYXZh) | `56.94% <100.00%> (ø)` | |
   | [...er/transaction/queue/TransactionalMessageUtil.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vcXVldWUvVHJhbnNhY3Rpb25hbE1lc3NhZ2VVdGlsLmphdmE=) | `80.00% <100.00%> (ø)` | |
   | [...apache/rocketmq/common/message/MessageDecoder.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRGVjb2Rlci5qYXZh) | `77.65% <100.00%> (ø)` | |
   | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `62.63% <100.00%> (ø)` | |
   | [...cketmq/remoting/protocol/RemotingSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlbW90aW5nU2VyaWFsaXphYmxlLmphdmE=) | `62.50% <100.00%> (ø)` | |
   | [...cketmq/remoting/protocol/RocketMQSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JvY2tldE1RU2VyaWFsaXphYmxlLmphdmE=) | `86.45% <100.00%> (ø)` | |
   | [...etmq/tools/command/message/SendMessageCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWVzc2FnZS9TZW5kTWVzc2FnZUNvbW1hbmQuamF2YQ==) | `74.32% <100.00%> (ø)` | |
   | [...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==) | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/rocketmq/pull/4024/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4574d59...be4de18](https://codecov.io/gh/apache/rocketmq/pull/4024?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhiboo commented on a change in pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
lizhiboo commented on a change in pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#discussion_r838427296



##########
File path: example/src/main/java/org/apache/rocketmq/example/openmessaging/SimpleProducer.java
##########
@@ -40,15 +39,15 @@ public static void main(String[] args) {
         System.out.printf("Producer startup OK%n");
 
         {
-            Message message = producer.createBytesMessage("OMS_HELLO_TOPIC", "OMS_HELLO_BODY".getBytes(Charset.forName("UTF-8")));

Review comment:
       Why not use StandardCharsets.UTF_8 ? IMO, some os may use gbk as default decoder. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#issuecomment-1082770004


   
   [![Coverage Status](https://coveralls.io/builds/47818477/badge)](https://coveralls.io/builds/47818477)
   
   Coverage decreased (-0.01%) to 51.93% when pulling **be4de18eb0593b2ee93b487786a8a8adcb822eb4 on 6U-U9:develop** into **4574d59f4b8d28888576293db6c019a1d2c37adb on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] 6U-U9 commented on pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
6U-U9 commented on pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#issuecomment-1082745427


   #4068 I have created an issue for this PR.
   And accoding to the massage sending process in SimplePullConsumer, there is no need for specify Charset in SimpleProducer, so I removed them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on pull request #4024: Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #4024:
URL: https://github.com/apache/rocketmq/pull/4024#issuecomment-1081656760


   Can an ISSUE be created for this PR? 
   In addition, can the code formatting of SimpleProducer be adjusted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org