You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2012/01/08 08:37:39 UTC
[jira] [Created] (HBASE-5145) HMasterCommandLine's -minServers
seems to be useless.
HMasterCommandLine's -minServers seems to be useless.
-----------------------------------------------------
Key: HBASE-5145
URL: https://issues.apache.org/jira/browse/HBASE-5145
Project: HBase
Issue Type: Sub-task
Components: master
Affects Versions: 0.94.0
Reporter: Harsh J
HMasterCommandLine gets a number via -minServers opt. and sets it to a config param "hbase.regions.server.count.min".
This config is not used anywhere else.
Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5145) HMasterCommandLine's -minServers
seems to be useless.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5145:
---------------------------
Attachment: HBASE-5145.patch
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
> Key: HBASE-5145
> URL: https://issues.apache.org/jira/browse/HBASE-5145
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5145) HMasterCommandLine's -minServers
seems to be useless.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-5145:
---------------------------
Assignee: Harsh J
Status: Patch Available (was: Open)
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
> Key: HBASE-5145
> URL: https://issues.apache.org/jira/browse/HBASE-5145
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5145) HMasterCommandLine's -minServers
seems to be useless.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409286#comment-13409286 ]
Zhihong Ted Yu commented on HBASE-5145:
---------------------------------------
Here is javadoc for waitForRegionServers():
{code}
* Wait for the region servers to report in.
* We will wait until one of this condition is met:
* - the master is stopped
* - the 'hbase.master.wait.on.regionservers.timeout' is reached
* - the 'hbase.master.wait.on.regionservers.maxtostart' number of
* region servers is reached
* - the 'hbase.master.wait.on.regionservers.mintostart' is reached AND
* there have been no new region server in for
* 'hbase.master.wait.on.regionservers.interval' time
{code}
If we expose 'hbase.master.wait.on.regionservers.mintostart', we should expose the other parameters as well ?
Also, the following is difficult to follow:
{code}
opt.addOption("minServers", true, "Minimum RegionServers needed to host user tables");
{code}
We should change the wording.
What do you think ?
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
> Key: HBASE-5145
> URL: https://issues.apache.org/jira/browse/HBASE-5145
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5145) HMasterCommandLine's -minServers
seems to be useless.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409289#comment-13409289 ]
Harsh J commented on HBASE-5145:
--------------------------------
bq. If we expose 'hbase.master.wait.on.regionservers.mintostart', we should expose the other parameters as well ?
We already do expose those properties (they are read from configs).
The plan is to properly make them use constants via HBASE-3274, which I've been slacking on lately but plan to rebase and resume again very soon.
So for this change, which in reality was only removing the useless minServers' set property and using the right one (a bug), I thought I'll also constantize them as I go.
bq. We should change the wording.
Agree, and will do.
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
> Key: HBASE-5145
> URL: https://issues.apache.org/jira/browse/HBASE-5145
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5145) HMasterCommandLine's -minServers
seems to be useless.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409211#comment-13409211 ]
Hadoop QA commented on HBASE-5145:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535624/HBASE-5145.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2350//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2350//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2350//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2350//console
This message is automatically generated.
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
> Key: HBASE-5145
> URL: https://issues.apache.org/jira/browse/HBASE-5145
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" instead?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira