[GitHub] [geode] aditya87 opened pull request #2874: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

["aditya87 (GitHub)" <gi...@apache.org>]

- Store config via generating a RegionConfig object rather than an XML entity
- For clarity, rename getters that return a "Boolean" object rather than a boolean primitive as prefixed by "get" rather than "is". This communicates nullability to the caller. A bit of history here -- this code was originally generated by lombok (https://projectlombok.org/), which we subsequently backed out. But we like the clarity of this pattern.
- Create a "RegionConfigFactory" to generate a RegionConfig object from RegionFunctionArgs.
- Reduce null-related side effects in some setters in RegionFunctionArgs.

Signed-off-by: Peter Tran <pt...@pivotal.io>
Signed-off-by: Aditya Anchuri <aa...@pivotal.io>
Signed-off-by: Peter Tran <pt...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #2874: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Why was this needed? `mavenCentral` is already a repository for `allprojects`, added in the project root `build.gradle`

[ Full content available at: https://github.com/apache/geode/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2874: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

["aditya87 (GitHub)" <gi...@apache.org>]

Sorry -- this might have been added when I temporarily brought in lombok, I realize it's unnecessary. Will remove.

[ Full content available at: https://github.com/apache/geode/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on issue #2874: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

["aditya87 (GitHub)" <gi...@apache.org>]

Withdrawing, will recreate once we fix some issues

[ Full content available at: https://github.com/apache/geode/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 closed pull request #2874: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

["aditya87 (GitHub)" <gi...@apache.org>]

[ pull request closed by aditya87 ]

[ Full content available at: https://github.com/apache/geode/pull/2874 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org