You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/08/05 01:13:13 UTC
[jira] [Commented] (HELIX-376) Remove HelixConnection/HelixManager
duplicate code
[ https://issues.apache.org/jira/browse/HELIX-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085470#comment-14085470 ]
Hudson commented on HELIX-376:
------------------------------
SUCCESS: Integrated in helix #1277 (See [https://builds.apache.org/job/helix/1277/])
[HELIX-376] Remove HelixConnection/HelixManager duplicate code (zzhang: rev 02165c5203ffd226ad23d310ee3e027c9b761f65)
* helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java
* helix-core/src/test/java/org/apache/helix/ZkTestHelper.java
* helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java
* helix-core/src/test/java/org/apache/helix/tools/TestHelixAdminCli.java
* helix-core/src/main/java/org/apache/helix/HelixAutoController.java
* helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java
* helix-core/src/test/java/org/apache/helix/integration/TestSessionExpiryInTransition.java
* helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java
* helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ControllerResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisableResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisable.java
* recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/MyTaskService.java
* helix-core/src/main/java/org/apache/helix/HelixService.java
* helix-core/src/test/java/org/apache/helix/TestHelper.java
* helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConfigResource.java
* helix-core/src/test/java/org/apache/helix/TestZKCallback.java
* helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java
* helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java
* helix-core/src/test/java/org/apache/helix/mock/controller/MockController.java
* helix-core/src/test/java/org/apache/helix/integration/TestInvalidResourceRebalance.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestParticipantNameCollision.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
* helix-core/src/test/java/org/apache/helix/integration/TestRestartParticipant.java
* helix-core/src/test/java/org/apache/helix/integration/manager/MockParticipantManager.java
* helix-core/src/test/java/org/apache/helix/integration/manager/ClusterDistributedController.java
* helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java
* helix-core/src/test/java/org/apache/helix/manager/zk/MockController.java
* helix-core/src/test/java/org/apache/helix/integration/TestCustomIdealState.java
* helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java
* helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java
* helix-core/src/test/java/org/apache/helix/integration/TestEnablePartitionDuringDisable.java
* helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java
* helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
* helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java
* helix-core/src/test/java/org/apache/helix/integration/TestReelectedPipelineCorrectness.java
* helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java
* helix-core/src/test/java/org/apache/helix/manager/zk/MockParticipant.java
* helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZKLiveInstanceData.java
* recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java
* helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMMain.java
* helix-core/src/test/java/org/apache/helix/manager/zk/MockMultiClusterController.java
* helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java
* helix-core/src/main/java/org/apache/helix/HelixMultiClusterController.java
* helix-core/src/test/java/org/apache/helix/testutil/TestUtil.java
* helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java
* helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
* helix-core/src/test/java/org/apache/helix/integration/TestPauseSignal.java
* helix-core/src/main/java/org/apache/helix/api/id/AdministratorId.java
* helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestControllerManager.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java
* helix-core/src/test/java/org/apache/helix/integration/TestCorrectnessOnConnectivityLoss.java
* helix-core/src/test/java/org/apache/helix/api/TestNewStages.java
* helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java
* helix-core/src/test/java/org/apache/helix/Mocks.java
* helix-core/src/test/java/org/apache/helix/integration/TestExternalViewUpdates.java
* helix-core/src/test/java/org/apache/helix/integration/TestSwapInstance.java
* helix-core/src/test/java/org/apache/helix/messaging/handling/TestResourceThreadpoolSize.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java
* helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java
* helix-core/src/test/java/org/apache/helix/messaging/handling/TestConfigThreadpoolSize.java
* helix-core/src/test/java/org/apache/helix/manager/zk/ZkConnTestHelper.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixMultiClusterController.java
* helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java
* helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
* helix-core/src/test/java/org/apache/helix/integration/TestDriver.java
* helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java
* helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java
* helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java
* helix-core/src/test/java/org/apache/helix/integration/TestNullReplica.java
* helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
* helix-core/src/test/java/org/apache/helix/integration/ZkStandAloneCMTestBase.java
* helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyModel.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java
* helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java
* helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java
* helix-core/src/test/java/org/apache/helix/integration/TestRedefineStateModelDef.java
* helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
* helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
* helix-core/src/test/java/org/apache/helix/TestConfigAccessor.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
* helix-core/src/test/java/org/apache/helix/integration/TestDropResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestCarryOverBadCurState.java
* helix-core/src/test/java/org/apache/helix/integration/TestDrop.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetPartitionState.java
* helix-core/src/main/java/org/apache/helix/model/ConfigScope.java
* helix-core/src/main/java/org/apache/helix/HelixManager.java
* helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java
* helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java
* helix-core/src/test/java/org/apache/helix/integration/TestAutoIsWithEmptyMap.java
* helix-core/src/test/java/org/apache/helix/integration/TestEntropyFreeNodeBounce.java
* helix-core/src/test/java/org/apache/helix/store/zk/TestZkManagerWithAutoFallbackStore.java
* helix-core/src/test/java/org/apache/helix/integration/TestClusterStartsup.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAutoController.java
* helix-core/src/test/java/org/apache/helix/integration/TestCleanupExternalView.java
* helix-core/src/test/java/org/apache/helix/integration/TestHelixCustomCodeRunner.java
* helix-core/src/main/java/org/apache/helix/model/builder/ConfigScopeBuilder.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixRoleDefaultImpl.java
* helix-core/src/test/java/org/apache/helix/mock/controller/MockControllerProcess.java
* helix-core/src/test/java/org/apache/helix/integration/TestSharedConnection.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkStateChangeListener.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java
* helix-core/src/main/java/org/apache/helix/ConfigChangeListener.java
* helix-core/src/test/java/org/apache/helix/integration/TestBasicSpectator.java
* helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkManagerFlappingDetection.java
* helix-core/src/test/java/org/apache/helix/integration/TestZkSessionExpiry.java
* helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java
* helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java
* helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMSessionExpiry.java
* helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java
* helix-core/src/test/java/org/apache/helix/integration/IntegrationTest.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ControllerManagerHelper.java
* helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java
* helix-core/src/main/java/org/apache/helix/HelixConnection.java
* helix-core/src/main/java/org/apache/helix/HelixRole.java
* helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
* helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java
* helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackHandler.java
* helix-core/src/test/java/org/apache/helix/manager/MockListener.java
* helix-core/src/test/java/org/apache/helix/model/TestConstraint.java
* helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConstraintResource.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestHandleNewSession.java
* helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestLiveInstanceBounce.java
> Remove HelixConnection/HelixManager duplicate code
> --------------------------------------------------
>
> Key: HELIX-376
> URL: https://issues.apache.org/jira/browse/HELIX-376
> Project: Apache Helix
> Issue Type: Sub-task
> Reporter: Kanak Biscuitwala
> Assignee: Zhen Zhang
> Labels: kanban
>
> Use an adaptor where the removed one is required.
--
This message was sent by Atlassian JIRA
(v6.2#6252)