You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/02/17 05:27:58 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

virajjasani commented on a change in pull request #2959:
URL: https://github.com/apache/hbase/pull/2959#discussion_r577334939



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -252,6 +252,7 @@ private void dequeueCurrentLog() throws IOException {
     LOG.debug("EOF, closing {}", currentPath);
     closeReader();
     logQueue.remove();
+    setCurrentPath(null);

Review comment:
       I don't have good context here, but is it possible to add a small test? That could help anyone get to know this bit better, it's fine though if it is too complicated to add it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org