You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2015/11/01 04:50:59 UTC
Re: Review Request 38089: SQOOP-2335 : Hcatalog external table support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38089/#review104652
-----------------------------------------------------------
Please run through checkstyle.
src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1678)
<https://reviews.apache.org/r/38089/#comment162901>
Spaces - please fix whitespaces
src/java/org/apache/sqoop/tool/ImportTool.java (line 536)
<https://reviews.apache.org/r/38089/#comment162902>
Please fix the wording
Also can you please make sure this is tested with multiple mapper scenario. We may have to identify the hive version this will work correctly (we may be having issues with 0.11 and earlier) - So, may need to identify 0.13.1 as the new basic hive version.
- Venkat Ranganathan
On Sept. 23, 2015, 4:29 a.m., Rakesh Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38089/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 4:29 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop currently doesnt support creating external tables while importing data to hcatalog tables. This patch adds support to create hcatalog tables ehile importing data.
>
>
> Diffs
> -----
>
> src/docs/user/hcatalog.txt 99ae4f5
> src/java/org/apache/sqoop/SqoopOptions.java db92b30
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec
> src/java/org/apache/sqoop/tool/ImportTool.java 39af42c
> src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION
> src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725
> src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870
> src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f
> src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38089/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Rakesh Sharma
>
>