[jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

Note that this commit removes the ability to list multiple containers
in the same command.  Callers should issue multiple commands instead.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds-karaf list-directory

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-karaf/pull/16

-- Commit Summary --

  * Add ability to list a directory within a container

-- File Changes --

    M commands/src/main/java/org/jclouds/karaf/commands/blobstore/BlobListCommand.java (66)

-- Patch Links --

https://github.com/jclouds/jclouds-karaf/pull/16.patch
https://github.com/jclouds/jclouds-karaf/pull/16.diff

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Phillips <no...@github.com>]

>  
> -   @Option(name = "-a", aliases = "--all", description = "List all containers", required = false)
> -   boolean listAllContainers = false;
> +   @Argument(index = 1, name = "directoryPath", description = "Directory path to list", required = false)

How do you "list a directory path"? Or is this "Path to directory to list"?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16/files#r4846052

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Phillips <no...@github.com>]

>  
> -            String marker = blobStoreMetadatas.getNextMarker();
> -            if (marker == null) {
> -               break;
> -            }
> +         Collections.sort(blobNames);

Any reason we're sorting the output and not printing it in the order returned by the underlying system?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16/files#r4846072

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[BuildHive <no...@github.com>]

[jclouds » jclouds-karaf #130](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/130/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-19843709

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Phillips <no...@github.com>]

Since we're removing functionality without deprecating it (should we be doing this?), could you add an example to this ticket or the readme about how to rewrite code to replicate the old behaviour?

Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-19919027

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

Committed to master and 1.6.x.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-21017247

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

Closed #16.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

>  
> -   @Option(name = "-a", aliases = "--all", description = "List all containers", required = false)
> -   boolean listAllContainers = false;
> +   @Argument(index = 1, name = "directoryPath", description = "Directory path to list", required = false)

Replaced with, "List blobs only in this directory path"

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16/files#r4849525

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

>  
> -            String marker = blobStoreMetadatas.getNextMarker();
> -            if (marker == null) {
> -               break;
> -            }
> +         Collections.sort(blobNames);

I added this some time back to beautify output.  However, I now think that returning the underlying order is better and we should add a --marker flag to allow users to resume from where they left off.  I will address this in a subsequent commit.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16/files#r4849451

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

@timuralp This commit will make the list output sane as we discussed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-20151845

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Gaul <no...@github.com>]

I doubt anyone used the existing multi-container functionality.  I will add something to the release notes about this and future breaking changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-19927952

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[BuildHive <no...@github.com>]

[jclouds » jclouds-karaf #136](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/136/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-19931204

Re: [jclouds-karaf] Add ability to list a directory within a container (#16)

[Andrew Phillips <no...@github.com>]

> I will add something to the release notes about this and future breaking changes.

Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/16#issuecomment-19928170