You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/01/10 19:14:19 UTC
[PR] [SPARK-46658][DOCS] Loosen Ruby dependency specification [spark]
nchammas opened a new pull request, #44667:
URL: https://github.com/apache/spark/pull/44667
### What changes were proposed in this pull request?
As [promised here][1], this change loosens our Ruby dependency specification so that Bundler can update transitive dependencies more easily.
Other changes included:
- Remove the direct dependency on webrick, because Jekyll [fixed the problem][2] that caused us to add it in the first place.
- Add explanatory comments to parts of the document generation process that are not obvious.
[1]: https://github.com/apache/spark/pull/44628#discussion_r1445151689
[2]: https://github.com/jekyll/jekyll/pull/8524
We can still build our docs using Ruby 2.7, but we should push devs to install Ruby 3 since Ruby 2 is [EOL][3] and we are unable to upgrade some of our doc dependencies until we're running Ruby 3.
[3]: https://www.ruby-lang.org/en/news/2022/04/12/ruby-2-7-6-released/
### Why are the changes needed?
Make the document building process more robust to future updates coming from the Ruby ecosystem.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I built and reviewed the docs on both Ruby 2.7.8 and Ruby 3.3.0 using the following command:
```sh
SKIP_SCALADOC=1 SKIP_PYTHONDOC=1 SKIP_RDOC=1 bundle exec jekyll build
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46658][DOCS] Loosen Ruby dependency specification [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44667:
URL: https://github.com/apache/spark/pull/44667#issuecomment-1885961407
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46658][DOCS] Loosen Ruby dependency specification [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44667:
URL: https://github.com/apache/spark/pull/44667#issuecomment-1885577128
cc @HyukjinKwon @srowen - We should update the build images to include Ruby 3.
https://github.com/apache/spark/blob/11ac856919815f7ef2e534e205d1ed83398de136/dev/create-release/spark-rm/Dockerfile#L84-L85
https://github.com/apache/spark/blob/4957c1a5fd4218ff47c7ed2b75199cb9c499e40e/dev/infra/Dockerfile#L59-L60
I would do this myself, but non-committers cannot really test changes to these images fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46658][DOCS] Loosen Ruby dependency specification [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44667: [SPARK-46658][DOCS] Loosen Ruby dependency specification
URL: https://github.com/apache/spark/pull/44667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org