You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/11 06:25:21 UTC
[GitHub] [dubbo-go] wenxuwan opened a new pull request #926: Fix: #925
wenxuwan opened a new pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926
try to fix #925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #926: fix client block until timeout when provider return with PackageResponse_Exception
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926#discussion_r541826529
##########
File path: protocol/dubbo/impl/codec.go
##########
@@ -163,15 +163,12 @@ func (c *ProtocolCodec) Decode(p *DubboPackage) error {
if p.IsResponseWithException() {
logger.Infof("response with exception: %+v", p.Header)
decoder := hessian.NewDecoder(body)
+ p.Body = &ResponsePayload{}
Review comment:
here, p.Body also be nil, so will return perrors.Errorf("java exception:%s", exception.(string)), this will cause the client timeout always.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #926: fix client block until timeout when provider return with PackageResponse_Exception
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #926: Fix: #925
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926#issuecomment-743136206
@wenxuwan pls change ur pr title to let users know what this pr do when release 1.5.5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on pull request #926: fix client block until timeout when provider return with PackageResponse_Exception
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926#issuecomment-743154211
> @wenxuwan pls change ur pr title to let users know what this pr do when release 1.5.5
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #926: fix client block until timeout when provider return with PackageResponse_Exception
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926#discussion_r541582958
##########
File path: protocol/dubbo/impl/codec.go
##########
@@ -163,15 +163,12 @@ func (c *ProtocolCodec) Decode(p *DubboPackage) error {
if p.IsResponseWithException() {
logger.Infof("response with exception: %+v", p.Header)
decoder := hessian.NewDecoder(body)
+ p.Body = &ResponsePayload{}
Review comment:
why？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #926: Fix: #925
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926#issuecomment-743004252
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=h1) Report
> Merging [#926](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=desc) (9e0fd61) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4ea5d0a7e72312f70decf033810291b0a134c661?el=desc) (4ea5d0a) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #926 +/- ##
===========================================
- Coverage 59.83% 59.76% -0.07%
===========================================
Files 260 260
Lines 12854 12852 -2
===========================================
- Hits 7691 7681 -10
- Misses 4202 4208 +6
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/926/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `39.86% <0.00%> (+0.53%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/926/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/926/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.60% <0.00%> (-3.27%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/926/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/926/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=footer). Last update [4ea5d0a...9e0fd61](https://codecov.io/gh/apache/dubbo-go/pull/926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org