You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/02 13:51:05 UTC
[GitHub] [nifi] gitfirenz opened a new pull request #4383: NIFI-7522 - Add Kafka 2.5 Processors set
gitfirenz opened a new pull request #4383:
URL: https://github.com/apache/nifi/pull/4383
#### Description of PR
Add Kafka 2.5 Processors set (NIFI-7522), in order to :
* Have the last fixes from Kafka
* Use the static Membership Consumers (to reduce rebalancing)
It's a copy/paste from Kafka 2.0 processors, without new feature.
Notes :
- Kafka 2.5 use scala 2.12, and not 2.11 anymore.
- Kafka 2.6 is late, maybe the next NIFI step could be Kafka 3.x.
- To reduce the convenient store size, the idea is to put in profile the 0.9/0.10 processors (PR created by MikeThomsen : https://github.com/apache/nif
[NIFI-7522 - Template-Test.zip](https://github.com/apache/nifi/files/4864666/NIFI-7522.-.Template-Test.zip)
i/pull/4364)
- A 1st draft PR with some comments was there : https://github.com/apache/nifi/pull/4346 (closed because i PR from my master and not a dedicated branch).
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Testing
**Infra :**
The static kafka membership has been tested with a kafka 2.5 single node, topic "test" with 5 partitions (Centos 8 Stream 20191219 with JDK8, Windows 10 with JDK8)
**Code :** A NIFI template with 3 consumers is attached (NIFI template).
The 3 consumers have a group.instance.id 01 02 03 and a session.timeout.ms of 10minutes.
**Results :**
* The consumer consumes (like in 2.0)
* The kafka server log show the join of the static consumer : "Static member Some(01) of group CG with unknown member id rejoins".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4383: NIFI-7522 - Add Kafka 2.5 Processors set
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4383:
URL: https://github.com/apache/nifi/pull/4383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4383: NIFI-7522 - Add Kafka 2.5 Processors set
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4383:
URL: https://github.com/apache/nifi/pull/4383#issuecomment-668817625
Thanks for putting this together. Tested the processors and everything seems to work as expected.
The 2.5 kafka client brings in one additional jar for zstd-jni which has a BSD license that needs to be account for in the LICENSE of the NAR and the overall assembly. I will take care of that as part of merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org