[GitHub] [guacamole-server] necouchman commented on a change in pull request #320: GUACAMOLE-1245: Add support for specifying Wake-on-LAN port.

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #320:
URL: https://github.com/apache/guacamole-server/pull/320#discussion_r549836939



##########
File path: src/libguac/guacamole/wol-constants.h
##########
@@ -39,13 +39,5 @@
  */
 #define GUAC_WOL_PACKET_SIZE 102
 
-/**
- * The port number that the magic packet should contain as the destination.  In
- * reality this doesn't matter all that much, since the packet is not usually
- * processed by a full IP stack, but defining one is considered a standard
- * practice.
- */
-#define GUAC_WOL_PORT 9
-

Review comment:
       It gets moved over to the `defaults.h` file as a default value, since we're now allowing it to be specified. UDP port 9 is officially the "Discard Protocol", and has been unofficially adopted for Wake-on-LAN. So, it technically isn't the "Wake-on-LAN" port, just the one that gets used most times.
   
   I'm happy to back this change out and just leave it as is, using this value as the default, I was just recalling the discussion we had about defaults when originally implementing this support and trying to put it in the proper place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org