You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Trevor Turner (Jira)" <ji...@apache.org> on 2021/10/21 01:00:01 UTC
[jira] [Comment Edited] (SOLR-15700) Fix include path consistency
in bin/solr shell wrapper
[ https://issues.apache.org/jira/browse/SOLR-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432147#comment-17432147 ]
Trevor Turner edited comment on SOLR-15700 at 10/21/21, 12:59 AM:
------------------------------------------------------------------
I'm very open to creating a PR for this! Apologies that I'm still a bit new at contributing code to larger projects and must have glossed over the guidelines for git, patch formatting, and PRs in the contributor guide!
You have the right of it with the patch - I am simply making the paths match and anticipate this to be a low impact fix!
As I've explored the source some more, I see what you mean by this being one of the harder parts of Solr to test. While there's potential for additional environment/configuration test suites in bin-test, I see some potential challenges of implementing them cleanly without root.
I have just submitted the PR at [https://github.com/apache/solr/pull/358]
was (Author: deploymentdog):
I'm very open to creating a PR for this! Apologies that I'm still a bit new at contributing code to larger projects and must have glossed over the guidelines for git, patch formatting, and PRs in the contributor guide!
You have the right of it with the patch - I am simply making the paths match and anticipate this to be a low impact fix!
As I've explored the source some more, I see what you mean by this being one of the harder parts of Solr to test. While there's potential for additional environment/configuration test suites bin-test, I see some potential challenges of implementing them cleanly without root.
I have just submitted the PR at https://github.com/apache/solr/pull/358
> Fix include path consistency in bin/solr shell wrapper
> ------------------------------------------------------
>
> Key: SOLR-15700
> URL: https://issues.apache.org/jira/browse/SOLR-15700
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
> Affects Versions: 8.10
> Environment: CentOS 7, Solr 8.10.1
> –
> openjdk version "11.0.12" 2021-07-20 LTS
> OpenJDK Runtime Environment 18.9 (build 11.0.12+7-LTS)
> OpenJDK 64-Bit Server VM 18.9 (build 11.0.12+7-LTS, mixed mode, sharing
> --
> GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
> Copyright (C) 2011 Free Software Foundation, Inc.
> Reporter: Trevor Turner
> Assignee: David Eric Pugh
> Priority: Minor
> Labels: easyfix, patch, pull-request-available
> Attachments: fix-solr-sh-include-paths.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The shell script {{bin/solr}} states the paths it will search for {{solr.in.sh}} in a comment near the top of the script, however, not all of these paths are consistent with the logic that actually searches for the file.
> Since one can either edit the script in their own packaging/deployment or simply use the {{SOLR_INCLUDE}} env variable, this doesn't pose much of a problem, but is a minor annoyance if configuring a package based on this comment.
> I've created and attached a patch that includes all paths consistently in both places.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org