[GitHub] [helix] jiajunwang commented on a change in pull request #490: DRAFT: Add the metric components for WAGED rebalancer

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #490: DRAFT: Add the metric components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r328440100
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -97,24 +100,25 @@ public WagedRebalancer(HelixManager helixManager,
         // Mapping calculator will translate the best possible assignment into the applicable state
         // mapping based on the current states.
         // TODO abstract and separate the main mapping calculator logic from DelayedAutoRebalancer
-        new DelayedAutoRebalancer());
+        new DelayedAutoRebalancer(), helixManager.getClusterName());
   }
 
   private WagedRebalancer(AssignmentMetadataStore assignmentMetadataStore,
-      RebalanceAlgorithm algorithm, MappingCalculator mappingCalculator) {
+      RebalanceAlgorithm algorithm, MappingCalculator mappingCalculator, String clusterName) {
 
 Review comment:
   The private constructor can accept the MetricCollector directly. So you don't need to bother how the MetricCollector is created in the rebalancer class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org