You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Simon Nash (JIRA)" <de...@tuscany.apache.org> on 2011/02/02 09:43:29 UTC
[jira] Created: (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Incorrect WSDL generated for bare parameter style
-------------------------------------------------
Key: TUSCANY-3824
URL: https://issues.apache.org/jira/browse/TUSCANY-3824
Project: Tuscany
Issue Type: Bug
Components: Java SCA Axis Binding Extension
Affects Versions: Java-SCA-1.6.1
Reporter: Simon Nash
Assignee: Simon Nash
Fix For: Java-SCA-1.x
For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Posted by "Scott Kurz (Commented) (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165665#comment-13165665 ]
Scott Kurz commented on TUSCANY-3824:
-------------------------------------
See also, https://issues.apache.org/jira/browse/TUSCANY-3995
not that I think it necessarily addresses every aspect of this JIRA
> Incorrect WSDL generated for bare parameter style
> -------------------------------------------------
>
> Key: TUSCANY-3824
> URL: https://issues.apache.org/jira/browse/TUSCANY-3824
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Axis Binding Extension
> Affects Versions: Java-SCA-1.6.1
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.x
>
>
> For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
> The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Posted by "Scott Kurz (Updated) (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Kurz updated TUSCANY-3824:
--------------------------------
Patch Info: Patch Available
Fix Version/s: (was: Java-SCA-1.x)
Java-SCA-2.x
> Incorrect WSDL generated for bare parameter style
> -------------------------------------------------
>
> Key: TUSCANY-3824
> URL: https://issues.apache.org/jira/browse/TUSCANY-3824
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Axis Binding Extension
> Affects Versions: Java-SCA-1.6.1
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-2.x
>
> Attachments: TUSCANY-3824.patch
>
>
> For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
> The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Posted by "Scott Kurz (Commented) (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214939#comment-13214939 ]
Scott Kurz commented on TUSCANY-3824:
-------------------------------------
Fixed in 2.x in r1292896.
> Incorrect WSDL generated for bare parameter style
> -------------------------------------------------
>
> Key: TUSCANY-3824
> URL: https://issues.apache.org/jira/browse/TUSCANY-3824
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Axis Binding Extension
> Affects Versions: Java-SCA-1.6.1
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-2.x
>
> Attachments: TUSCANY-3824.patch
>
>
> For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
> The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Posted by "Scott Kurz (Commented) (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214795#comment-13214795 ]
Scott Kurz commented on TUSCANY-3824:
-------------------------------------
Thanks Greg,
That looks good. I think I'm going to apply this to 2.x but not 1.x (and change the fix version), in spite of the fact that this was opened on 1.x.
It seems conceivable that it could break an app dependent on the current defaulting on soapAction.... and since 1.x has been officially released it seems better to leave that alone.
> Incorrect WSDL generated for bare parameter style
> -------------------------------------------------
>
> Key: TUSCANY-3824
> URL: https://issues.apache.org/jira/browse/TUSCANY-3824
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Axis Binding Extension
> Affects Versions: Java-SCA-1.6.1
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.x
>
> Attachments: TUSCANY-3824.patch
>
>
> For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
> The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Posted by "Greg Dritschler (Updated) (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Dritschler updated TUSCANY-3824:
-------------------------------------
Attachment: TUSCANY-3824.patch
I have attached a patch for this issue.
Interface2WSDLGenerator was already defaulting the global element name to the operation name for doc/lit/bare, but only if the @WebParam annotation was present. I corrected the code to perform the correct defaulting even when the @WebParam annotation is not used.
I did not change the part name. I could not find anything in the JAX-WS spec that requires a particular part name for doc/lit/bare.
I removed the non-standard defaulting of the SOAP action in both Interface2WSDLGenerator and WSDLDefinitionGenerator.
I ran into one issue in the tests. In itest/ws/holder-ws-service-multiple-outputs, Axis2 couldn't figure out how to dispatch OrderServiceBare.bareReviewOrderOutHolder() since it has an empty SOAP body (no input arguments). It turns out there is a fix for this in the Axis2 trunk.
http://svn.apache.org/viewvc?view=revision&revision=1004667
The fix is not in Axis2 1.5.3. I decided to work around this by adding a SOAP action to the bareReviewOrderOutHolder() method.
> Incorrect WSDL generated for bare parameter style
> -------------------------------------------------
>
> Key: TUSCANY-3824
> URL: https://issues.apache.org/jira/browse/TUSCANY-3824
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Axis Binding Extension
> Affects Versions: Java-SCA-1.6.1
> Reporter: Simon Nash
> Assignee: Simon Nash
> Fix For: Java-SCA-1.x
>
> Attachments: TUSCANY-3824.patch
>
>
> For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
> The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TUSCANY-3824) Incorrect WSDL generated for bare
parameter style
Posted by "Scott Kurz (Resolved) (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Kurz resolved TUSCANY-3824.
---------------------------------
Resolution: Fixed
Assignee: Scott Kurz (was: Simon Nash)
> Incorrect WSDL generated for bare parameter style
> -------------------------------------------------
>
> Key: TUSCANY-3824
> URL: https://issues.apache.org/jira/browse/TUSCANY-3824
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Axis Binding Extension
> Affects Versions: Java-SCA-1.6.1
> Reporter: Simon Nash
> Assignee: Scott Kurz
> Fix For: Java-SCA-2.x
>
> Attachments: TUSCANY-3824.patch
>
>
> For a method with @SOAPBinding(parameterStyle=SOAPBinding.ParameterStyle.BARE), the JAX-WS RI generates WSDL with a global element name and message part name that are the same as the operation name. Tuscany generates WSDL with a global element name and message part name of arg0, and it adds soapAction to provide the operation name.
> The JAX-WS specification says that the global element name and message part name must be the same as the operation name, so Tuscany is generating WSDL for bare operations that doesn't conform to the JAX-WS rules. The JAX-WS specification also says that soapAction should be null unless @WebMethod(action=....) is specified. The Tuscany WSDL generator should use the correct JAX-WS mapping for the global element name and message part name, and should remove the nonstandard addition of soapAction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira