You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/01/31 06:58:51 UTC
[incubator-doris] branch master updated: [fix](ut) fix abs function ut (#7938)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 2003da7 [fix](ut) fix abs function ut (#7938)
2003da7 is described below
commit 2003da7cf9a3f7a393cc67b45a9b5cf293499f1d
Author: Pxl <95...@qq.com>
AuthorDate: Mon Jan 31 14:58:29 2022 +0800
[fix](ut) fix abs function ut (#7938)
---
be/src/exprs/math_functions.cpp | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/be/src/exprs/math_functions.cpp b/be/src/exprs/math_functions.cpp
index 1bdd83f..345fb65 100644
--- a/be/src/exprs/math_functions.cpp
+++ b/be/src/exprs/math_functions.cpp
@@ -106,6 +106,11 @@ DoubleVal MathFunctions::e(FunctionContext* ctx) {
return DoubleVal(M_E);
}
+// libc++ did not have std::abs for int128
+__int128_t largeint_abs(__int128_t x) {
+ return x > 0 ? x : -x;
+}
+
DecimalV2Val MathFunctions::abs(FunctionContext* ctx, const doris_udf::DecimalV2Val& val) {
if (val.is_null) {
return DecimalV2Val::null();
@@ -113,7 +118,7 @@ DecimalV2Val MathFunctions::abs(FunctionContext* ctx, const doris_udf::DecimalV2
if (UNLIKELY(val.val == MIN_INT128)) {
return DecimalV2Val::null();
} else {
- return DecimalV2Val(val.val > 0 ? val.val : -val.val);
+ return DecimalV2Val(largeint_abs(val.val));
}
}
@@ -124,7 +129,7 @@ LargeIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::LargeIntVa
if (UNLIKELY(val.val == MIN_INT128)) {
return LargeIntVal::null();
} else {
- return LargeIntVal(val.val > 0 ? val.val : -val.val);
+ return LargeIntVal(largeint_abs(val.val));
}
}
@@ -132,28 +137,28 @@ LargeIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::BigIntVal&
if (val.is_null) {
return LargeIntVal::null();
}
- return LargeIntVal(__int128(std::abs(val.val)));
+ return LargeIntVal(largeint_abs(__int128(val.val)));
}
BigIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::IntVal& val) {
if (val.is_null) {
return BigIntVal::null();
}
- return BigIntVal(int64_t(std::abs(val.val)));
+ return BigIntVal(std::abs(int64_t(val.val)));
}
IntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::SmallIntVal& val) {
if (val.is_null) {
return IntVal::null();
}
- return IntVal(int32_t(std::abs(val.val)));
+ return IntVal(std::abs(int32_t(val.val)));
}
SmallIntVal MathFunctions::abs(FunctionContext* ctx, const doris_udf::TinyIntVal& val) {
if (val.is_null) {
return SmallIntVal::null();
}
- return SmallIntVal(int16_t(std::abs(val.val)));
+ return SmallIntVal(std::abs(int16_t(val.val)));
}
// Generates a UDF that always calls FN() on the input val and returns it.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org