[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4465: [TE] logs and precondition checks for pipeline re-tuning

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4465: [TE] logs and precondition checks for pipeline re-tuning
URL: https://github.com/apache/incubator-pinot/pull/4465#discussion_r306582704
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
 ##########
 @@ -138,8 +137,12 @@ public DetectionPipelineTaskRunner() {
         this.evaluationDAO.save(evaluationDTO);
       }
 
-      // run maintenance flow to update model
-      config = maintenanceFlow.maintain(config, Instant.now());
+      try {
+        // run maintenance flow to update model
+        config = maintenanceFlow.maintain(config, Instant.now());
+      } catch (Exception e) {
+        LOG.warn("Re-tune pipeline {} failed", config.getId(), e);
 
 Review comment:
   Added the counter. The counter will increment when the tuner is called

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org