You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/07 08:18:11 UTC

[GitHub] [zookeeper] yfxhust commented on a change in pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.

yfxhust commented on a change in pull request #1242: ZOOKEEPER-3712: Add setKeepAlive support for NIOServerCnxn.
URL: https://github.com/apache/zookeeper/pull/1242#discussion_r376262364
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
 ##########
 @@ -81,6 +81,11 @@
      */
     private long sessionId;
 
+    /**
+     * Client socket option for TCP keepalive
+     */
+    private final boolean clientTcpKeepAlive = Boolean.getBoolean("zookeeper.clientTcpKeepAlive");
+
 
 Review comment:
   Thanks your comments. Accept it. I add items in zookeeperAdmin in latest patch. Please review it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services