You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/14 13:42:24 UTC

[GitHub] [thrift] rglarix opened a new pull request #2260: THRIFT-5295 - makeThread and ThreadFactory extensible

rglarix opened a new pull request #2260:
URL: https://github.com/apache/thrift/pull/2260


   Signed-off-by: rglarix <rg...@users.noreply.github.com>
   
   <!-- Explain the changes in the pull request below: -->
   THRIFT-5295: This patch for cpp makes Thread and ThreadFactory customizable 
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [X] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [X] Did you squash your changes to a single commit?  (not required, but preferred)
   - [X] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2260: THRIFT-5295 - makeThread and ThreadFactory extensible

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2260:
URL: https://github.com/apache/thrift/pull/2260


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2260: THRIFT-5295 - makeThread and ThreadFactory extensible

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2260:
URL: https://github.com/apache/thrift/pull/2260#issuecomment-738357392


   Could you give this one more try and force push, so a new CI run gets triggered?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] rglarix commented on pull request #2260: THRIFT-5295 - makeThread and ThreadFactory extensible

Posted by GitBox <gi...@apache.org>.
rglarix commented on pull request #2260:
URL: https://github.com/apache/thrift/pull/2260#issuecomment-740028600


   done!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] rglarix commented on pull request #2260: THRIFT-5295 - makeThread and ThreadFactory extensible

Posted by GitBox <gi...@apache.org>.
rglarix commented on pull request #2260:
URL: https://github.com/apache/thrift/pull/2260#issuecomment-708985394


   Sorry, CI fails but it seems an appveyor problem still in the setup phase:
   [00:01:11] downloading mingw-w64-x86_64-libevent-2.1.10-1-any.pkg.tar.xz...
   [00:01:11] error: failed to commit transaction (unexpected error)
   [00:01:11] Errors occurred, no packages were upgraded.
   [00:01:11] Command exited with code 1
   
   Something similar with travis, compilation of cpp was fine, I just cannot understand why it fails. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org