You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hongjiang Zhang (Code Review)" <ge...@cloudera.org> on 2021/03/01 09:46:15 UTC

[kudu-CR] [KUDU-3252] a test to reproduce the issue KUDU-3252

Hongjiang Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17143


Change subject: [KUDU-3252] a test to reproduce the issue KUDU-3252
......................................................................

[KUDU-3252] a test to reproduce the issue KUDU-3252

This UT sometimes work fine and remove the wal directory when there are
2 FsManager calls CreateInitialFileSystemLayout()

I0301 17:41:34.293262 13841 fs_manager.cc:485] Removed file /tmp/kudutest-1000/fs_manager-test.BlockManagerTypes_FsManagerTestBase.TestInitFSInParallel_1.1614591693256906-12747/d1_/instance
I0301 17:41:34.293368 13841 fs_manager.cc:485] Removed file /tmp/kudutest-1000/fs_manager-test.BlockManagerTypes_FsManagerTestBase.TestInitFSInParallel_1.1614591693256906-12747/d2_/instance
I0301 17:41:34.293431 13841 fs_manager.cc:485] Removed file /tmp/kudutest-1000/fs_manager-test.BlockManagerTypes_FsManagerTestBase.TestInitFSInParallel_1.1614591693256906-12747/d3_/instance
I0301 17:41:34.293491 13841 fs_manager.cc:485] Removed file /tmp/kudutest-1000/fs_manager-test.BlockManagerTypes_FsManagerTestBase.TestInitFSInParallel_1.1614591693256906-12747/wal_/instance
I0301 17:41:34.293576 13841 fs_manager.cc:494] Removed dir /tmp/kudutest-1000/fs_manager-test.BlockManagerTypes_FsManagerTestBase.TestInitFSInParallel_1.1614591693256906-12747/wal_

Change-Id: I90af630ec0a6917b83bcd16e14c59b5300f770b7
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
2 files changed, 33 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/17143/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90af630ec0a6917b83bcd16e14c59b5300f770b7
Gerrit-Change-Number: 17143
Gerrit-PatchSet: 1
Gerrit-Owner: Hongjiang Zhang <ho...@ebay.com>

[kudu-CR] [KUDU-3252] a test to reproduce the issue KUDU-3252

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17143 )

Change subject: [KUDU-3252] a test to reproduce the issue KUDU-3252
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager-test.cc
File src/kudu/fs/fs_manager-test.cc:

http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager-test.cc@1206
PS1, Line 1206: threads.emplace_back([fsManager]() {
Consider using the Barrier primitive to synchronize the start of the threads.  For an example, you could check TEST_F(ClientTest, TestRetrieveAuthzTokenInParallel) test scenario in src/kudu/client/client-test.cc


http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager-test.cc@1207
PS1, Line 1207: fsManager->CreateInitialFileSystemLayout();
This call returns result status.  Does it make sense to capture the result per-thread and check it after joining the threads?


http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

PS1: 
Did you find these logging changes helpful if looking beyond the scope of the newly added test scenario?



-- 
To view, visit http://gerrit.cloudera.org:8080/17143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90af630ec0a6917b83bcd16e14c59b5300f770b7
Gerrit-Change-Number: 17143
Gerrit-PatchSet: 1
Gerrit-Owner: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 06 Mar 2021 17:48:51 +0000
Gerrit-HasComments: Yes