[GitHub] [hbase] Reidddddd commented on a change in pull request #1417: HBASE-24102 : Remove decommissioned RS from target servers while unlo…

[GitBox <gi...@apache.org>]

Reidddddd commented on a change in pull request #1417: HBASE-24102 : Remove decommissioned RS from target servers while unlo…
URL: https://github.com/apache/hbase/pull/1417#discussion_r402909372
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
 ##########
 @@ -432,6 +437,15 @@ public boolean unload() throws InterruptedException, ExecutionException, Timeout
         }
         // Remove RS present in the exclude file
         stripExcludes(regionServers);
+
+        // Remove decommissioned RS
+        Set<ServerName> decommissionedRS = new HashSet<>(admin.listDecommissionedRegionServers());
+        if (CollectionUtils.isNotEmpty(decommissionedRS)) {
+          regionServers.removeIf(decommissionedRS::contains);
+          LOG.debug("Excluded RegionServers from unloading regions to because they " +
 
 Review comment:
   Can just info level, it is not chatty, and information is useful for client as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services