You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "aswinshakil (via GitHub)" <gi...@apache.org> on 2025/06/02 08:54:02 UTC
Re: [PR] HDDS-10374. Make container scanner generate merkle trees during the scan [ozone]
aswinshakil commented on code in PR #7490:
URL: https://github.com/apache/ozone/pull/7490#discussion_r2120469383
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java:
##########
@@ -557,22 +515,15 @@ public void testDataChecksumReportedAtSCM() throws Exception {
db.getStore().flushDB();
}
- // TODO: Use On-demand container scanner to build the new container merkle tree. (HDDS-10374)
- Files.deleteIfExists(getContainerChecksumFile(container.getContainerData()).toPath());
- kvHandler.createContainerMerkleTreeFromMetadata(container);
+ datanodeStateMachine.getContainer().getContainerSet().scanContainer(containerID);
Review Comment:
```suggestion
datanodeStateMachine.getContainer().getContainerSet().scanContainerWithoutGap(containerID);
```
Need to change this in the whole test suite.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java:
##########
@@ -376,21 +368,14 @@ public void testContainerChecksumWithBlockMissing() throws Exception {
db.getStore().flushDB();
}
- // TODO: Use On-demand container scanner to build the new container merkle tree. (HDDS-10374)
- Files.deleteIfExists(getContainerChecksumFile(container.getContainerData()).toPath());
- kvHandler.createContainerMerkleTreeFromMetadata(container);
+ datanodeStateMachine.getContainer().getContainerSet().scanContainer(containerID);
Review Comment:
same here
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/dn/checksum/TestContainerCommandReconciliation.java:
##########
@@ -460,42 +445,15 @@ public void testContainerChecksumChunkCorruption() throws Exception {
db.getStore().flushDB();
}
- Files.deleteIfExists(getContainerChecksumFile(container.getContainerData()).toPath());
- kvHandler.createContainerMerkleTreeFromMetadata(container);
- // To set unhealthy for chunks that are corrupted.
+ datanodeStateMachine.getContainer().getContainerSet().scanContainer(containerID);
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org