[GitHub] [storm] srdo commented on a change in pull request #3131: STORM-3510: Track overflow count per taskId for resending backpressur…

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #3131: STORM-3510: Track overflow count per taskId for resending backpressur…
URL: https://github.com/apache/storm/pull/3131#discussion_r329326023
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java
 ##########
 @@ -39,6 +40,7 @@
 public class BackPressureTracker {
     static final Logger LOG = LoggerFactory.getLogger(BackPressureTracker.class);
     private final Map<Integer, BackpressureState> tasks;
+    private final Map<Integer, Integer> lastOverflowCount;
 
 Review comment:
   I think we could optimize a bit here by having a single map of taskId -> BackPressureState, and just add the last overflow count to the BackPressureState object. That way, transferLocalBatch can look up the BackPressureState once rather than looking up in both maps here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services