You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2005/08/26 23:04:09 UTC
DO NOT REPLY [Bug 35918] -
[PATCH] Shapes are slightly shifted with respect to lines on larger graphics
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35918>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35918
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From jeremias@apache.org 2005-08-26 23:04 -------
I did a few things on PDFGraphics2D to improve the situation:
http://svn.apache.org/viewcvs?rev=240344&view=rev
I didn't actually apply your patch but followed your example while refactoring
the code. Thanks all the same!
Your test case looks good to me now.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Re: DO NOT REPLY [Bug 35918] - [PATCH] Shapes are slightly shifted with respect to lines on larger graphics
Posted by Jeremias Maerki <de...@greenmail.ch>.
Thanks. I'm convinced now that I should rewrite PDFNumber.doubleOut().
On 01.09.2005 01:36:12 Thomas DeWeese wrote:
> Jeremias Maerki wrote:
> > Thanks for the hint. Sounds like rewriting PDFNumber.doubleOut using
> > DecimalFormat makes sense. May I ask what you used before switching to
> > DecimalFormat?
>
> Double.toString(double d),
>
> I just took a look, whats with the PDFNumber.doubleOut function????
> It rounds numbers n+0.05 > x > n-0.05 to n (where n is an integer)?
> That seems really hacky ;)
>
> Also I can almost assure you that NumberFormat will be _much_
> faster than the current code.
>
> > On 31.08.2005 14:32:01 Thomas DeWeese wrote:
> >
> >>>I did a few things on PDFGraphics2D to improve the situation:
> >>>http://svn.apache.org/viewcvs?rev=240344&view=rev
> >>
> >> BTW Batik saw a significant performance increase when we went
> >>to using a DecimalFormat object to write our strings.
> >
> >
> >
> >
> > Jeremias Maerki
> >
Jeremias Maerki
Re: DO NOT REPLY [Bug 35918] - [PATCH] Shapes are slightly shifted
with respect to lines on larger graphics
Posted by Thomas DeWeese <Th...@Kodak.com>.
Jeremias Maerki wrote:
> Thanks for the hint. Sounds like rewriting PDFNumber.doubleOut using
> DecimalFormat makes sense. May I ask what you used before switching to
> DecimalFormat?
Double.toString(double d),
I just took a look, whats with the PDFNumber.doubleOut function????
It rounds numbers n+0.05 > x > n-0.05 to n (where n is an integer)?
That seems really hacky ;)
Also I can almost assure you that NumberFormat will be _much_
faster than the current code.
> On 31.08.2005 14:32:01 Thomas DeWeese wrote:
>
>>>I did a few things on PDFGraphics2D to improve the situation:
>>>http://svn.apache.org/viewcvs?rev=240344&view=rev
>>
>> BTW Batik saw a significant performance increase when we went
>>to using a DecimalFormat object to write our strings.
>
>
>
>
> Jeremias Maerki
>
Re: DO NOT REPLY [Bug 35918] - [PATCH] Shapes are slightly shifted with respect to lines on larger graphics
Posted by Jeremias Maerki <de...@greenmail.ch>.
Thanks for the hint. Sounds like rewriting PDFNumber.doubleOut using
DecimalFormat makes sense. May I ask what you used before switching to
DecimalFormat?
On 31.08.2005 14:32:01 Thomas DeWeese wrote:
> > I did a few things on PDFGraphics2D to improve the situation:
> > http://svn.apache.org/viewcvs?rev=240344&view=rev
>
> BTW Batik saw a significant performance increase when we went
> to using a DecimalFormat object to write our strings.
Jeremias Maerki
Re: DO NOT REPLY [Bug 35918] - [PATCH] Shapes are slightly shifted
with respect to lines on larger graphics
Posted by Thomas DeWeese <Th...@Kodak.com>.
> I did a few things on PDFGraphics2D to improve the situation:
> http://svn.apache.org/viewcvs?rev=240344&view=rev
BTW Batik saw a significant performance increase when we went
to using a DecimalFormat object to write our strings.