You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by re...@apache.org on 2020/06/24 14:52:40 UTC
svn commit: r1879159 - in /jackrabbit/trunk/jackrabbit-jcr-server/src:
main/java/org/apache/jackrabbit/server/io/DirListingExportHandler.java
test/java/org/apache/jackrabbit/webdav/server/ConditionalsTest.java
Author: reschke
Date: Wed Jun 24 14:52:40 2020
New Revision: 1879159
URL: http://svn.apache.org/viewvc?rev=1879159&view=rev
Log:
JCR-4590: jcr-server: DirListingExportHandler sets empty Etag
Modified:
jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DirListingExportHandler.java
jackrabbit/trunk/jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/webdav/server/ConditionalsTest.java
Modified: jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DirListingExportHandler.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DirListingExportHandler.java?rev=1879159&r1=1879158&r2=1879159&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DirListingExportHandler.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DirListingExportHandler.java Wed Jun 24 14:52:40 2020
@@ -135,7 +135,6 @@ public class DirListingExportHandler imp
// properties (content length undefined)
context.setModificationTime(new Date().getTime());
context.setContentType("text/html", "UTF-8");
- context.setETag("");
// data
if (context.hasStream()) {
@@ -199,7 +198,6 @@ public class DirListingExportHandler imp
// properties (content length undefined)
context.setModificationTime(new Date().getTime());
context.setContentType("text/html", "UTF-8");
- context.setETag("");
// data
if (context.hasStream()) {
Modified: jackrabbit/trunk/jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/webdav/server/ConditionalsTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/webdav/server/ConditionalsTest.java?rev=1879159&r1=1879158&r2=1879159&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/webdav/server/ConditionalsTest.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/webdav/server/ConditionalsTest.java Wed Jun 24 14:52:40 2020
@@ -162,4 +162,16 @@ public class ConditionalsTest extends We
delete(testUri);
}
}
+
+ public void testGetCollectionEtag() throws IOException, ParseException {
+ String testUri = this.uri.toString() + (this.uri.toString().endsWith("/") ? "" : "/");
+ HttpGet get = new HttpGet(testUri);
+ HttpResponse response = this.client.execute(get, this.context);
+ int status = response.getStatusLine().getStatusCode();
+ assertEquals(200, status);
+ Header etag = response.getFirstHeader("etag");
+ if (etag != null) {
+ assertFalse("etag must not be empty", "".equals(etag.getValue()));
+ }
+ }
}