You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 20:06:10 UTC

[GitHub] [beam] damccorm opened a new issue, #20894: Conversion from Avro GenericRecords to Beam Rows takes too much time

damccorm opened a new issue, #20894:
URL: https://github.com/apache/beam/issues/20894

   While running TPC-DS SQL query 3 on Dataflow with a input dataset of 1TB I noticed the performancew was not good compared with a native version implemented with Raw GenericRecords.
   
   I enabled profiling and noticed that the performance of the Convert transform that converts Avro GenericRecords into Beam Rows is taking too much time, specially for those records that are relatively simple (not nested recordes / logical types or anything complex).
   
   There is definitely something odd that can be improved in this transformation.
   
   Imported from Jira [BEAM-12328](https://issues.apache.org/jira/browse/BEAM-12328). Original Jira may contain additional context.
   Reported by: iemejia.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] mosche commented on issue #20894: Conversion from Avro GenericRecords to Beam Rows takes too much time

Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on issue #20894:
URL: https://github.com/apache/beam/issues/20894#issuecomment-1669225358

   Wondering, have you done some more benchmarks @gabrywu ?
   
   There's been some improvements in the area, particularly improving performance of [RowWithGetters](https://github.com/apache/beam/pull/17172) which is the foundation for most schema providers. The [reverse direction](https://github.com/apache/beam/pull/27534) is still pending, I'll merge after the next release cut.
   
   Though, actually, having a quick look at the code, this unfortunately doesn't apply to `GenericRecord`s. `GenericRecordToRowFn` eagerly converts records to rows rather than just wrapping them and delegating field access the way it is done by `RowWithGetters`. That's absolutely worth improving!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] gabrywu commented on issue #20894: Conversion from Avro GenericRecords to Beam Rows takes too much time

Posted by "gabrywu (via GitHub)" <gi...@apache.org>.
gabrywu commented on issue #20894:
URL: https://github.com/apache/beam/issues/20894#issuecomment-1669175552

   any updates here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org