You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/22 08:48:14 UTC
[GitHub] [cordova-js] erisu commented on a change in pull request #207: Add
platforms used during tests as devDependencies
erisu commented on a change in pull request #207: Add platforms used during tests as devDependencies
URL: https://github.com/apache/cordova-js/pull/207#discussion_r305734017
##########
File path: package.json
##########
@@ -74,6 +74,8 @@
"globby": "^9.2.0"
},
"devDependencies": {
+ "cordova-android": "^8.0.0",
+ "cordova-ios": "^5.0.0",
Review comment:
Previous implementation seems to clone master and now it focuses on the current released major.
I suspect this is not an issue in travis or appveyor. What about during a platform release that uses COHO?
The COHO command I suspect is running off master. Will this make a conflict? See blow comment for the conflicting area...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org