[GitHub] [couchdb] nickva opened a new pull request #3089: Handle jiffy returning an iolist when encoding atts_since query string

[GitBox <gi...@apache.org>]

nickva opened a new pull request #3089:
URL: https://github.com/apache/couchdb/pull/3089


   ### Overview
   
   If we don't handle it, it throws an error when trying to encode the full URL
   string, for example:
   
   ```
   badarg,[
    {mochiweb_util,quote_plus,2,[{file,"src/mochiweb_util.erl"},{line,192}]},
    {couch_replicator_httpc,query_args_to_string,2,[{file,"src/couch_replicator_httpc.erl"},{line,421}]},
    {couch_replicator_httpc,full_url,2,[{file,"src/couch_replicator_httpc.erl"},{line,413}]},
    {couch_replicator_api_wrap,open_doc_revs,6,[{file,"src/couch_replicator_api_wrap.erl"},{line,255}]}
   ]
   ```
   
   This is also similar to what we did for open_revs encoding: https://github.com/apache/couchdb/commit/a2d0c4290dde2015e5fb6184696fec3f89c81a4b
   
   ### Testing recommendations
   
   `make check`
   
   ### Related Issues or Pull Requests
   
   https://github.com/apache/couchdb/commit/a2d0c4290dde2015e5fb6184696fec3f89c81a4b
   
   ### Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #3089: Handle jiffy returning an iolist when encoding atts_since query string

[GitBox <gi...@apache.org>]

nickva merged pull request #3089:
URL: https://github.com/apache/couchdb/pull/3089


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org