You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 14:13:41 UTC

[GitHub] [arrow-datafusion] jdye64 commented on a diff in pull request #3229: Add support for Partitioning::DistributeBy in expressions function

jdye64 commented on code in PR #3229:
URL: https://github.com/apache/arrow-datafusion/pull/3229#discussion_r952682134


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -220,7 +220,8 @@ impl LogicalPlan {
                 ..
             }) => match partitioning_scheme {
                 Partitioning::Hash(expr, _) => expr.clone(),
-                _ => vec![],

Review Comment:
   This bites me all the time in my code base. Good find! I ran this PR against the test I was seeing the issue in and it resolved my issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org