You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Tarasenko Evgeny <no...@github.com> on 2015/03/27 11:42:35 UTC

[jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/184

-- Commit Summary --

  * Parse image properties when get image metadata from headers.

-- File Changes --

    M openstack-glance/src/main/java/org/jclouds/openstack/glance/v1_0/functions/ParseImageDetailsFromHeaders.java (18)
    M openstack-glance/src/test/java/org/jclouds/openstack/glance/v1_0/functions/ParseImageDetailsFromHeadersTest.java (3)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/184.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/184.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Zack Shoylev <no...@github.com>.
Closed #184.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#event-277514904

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Zack Shoylev <no...@github.com>.
This is from the official docs:
"There may be multiple headers that begin with the prefix x-image-meta-property-. These headers are free-form key/value pairs that have been saved with the image metadata. The key is the string after x-image-meta-property- and the value is the value of the header"

I would like to have this description added to the code somewhere. However, it seems good as it is.

 +1

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-89407253

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Tarasenko Evgeny <no...@github.com>.
@zack-shoylev comment with description form docs was added.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-89726557

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Tarasenko Evgeny <no...@github.com>.
Looks like that build failed, because it could not fetch source code. How can I restart this build?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-87938092

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Ignasi Barrera <no...@github.com>.
Just commenting: rebuild please!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-87976375

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Tarasenko Evgeny <no...@github.com>.
@zack-shoylev maybe this description can be added to ImageField.PROPERTY enum value?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-89411645

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Zack Shoylev <no...@github.com>.
Squashed, merged, and backported.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-91341360

Re: [jclouds-labs-openstack] Parse image properties when get image metadata from headers. (#184)

Posted by Tarasenko Evgeny <no...@github.com>.
@nacx thank you!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/184#issuecomment-87991794