You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zheng Shao <zs...@gmail.com> on 2010/09/21 03:14:21 UTC
Re: Review Request: Fix HIVE-1378: Return value for map, array,
and struct needs to return a string.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/828/#review1273
-----------------------------------------------------------
trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java
<http://review.cloudera.org/r/828/#comment4326>
While this function works for most cases, there is no guarantee that it will work for nested map/array/struct, because toString() is not required to be implemented correctly for Objects in hive.
The preferred way would be to use ObjectInspectorUtils/ObjectInspectorConvertors to copy/convert <Object, ObjectInspector> to "Standard Object", and then convert to JDBC objects.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java
<http://review.cloudera.org/r/828/#comment4325>
Can we change the name to serializeField (here and in LazySimpleSerDe)?
- Zheng
On 2010-09-20 12:55:10, Steven Wong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/828/
> -----------------------------------------------------------
>
> (Updated 2010-09-20 12:55:10)
>
>
> Review request for Hive Developers.
>
>
> Summary
> -------
>
> HIVE-1606 is also fixed as a side effect.
>
>
> This addresses bug HIVE-1378.
> http://issues.apache.org/jira/browse/HIVE-1378
>
>
> Diffs
> -----
>
> trunk/build.xml 997983
> trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 997983
> trunk/conf/hive-default.xml 997983
> trunk/data/files/datatypes.txt PRE-CREATION
> trunk/data/scripts/input20_script 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 997983
> trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 997983
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 997983
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 997983
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 997983
> trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 997983
> trunk/ql/src/test/results/compiler/plan/input20.q.xml 997983
> trunk/ql/src/test/results/compiler/plan/input4.q.xml 997983
> trunk/ql/src/test/results/compiler/plan/input5.q.xml 997983
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 997983
>
> Diff: http://review.cloudera.org/r/828/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven
>
>
Re: Review Request: Fix HIVE-1378: Return value for map, array,
and struct needs to return a string.
Posted by Steven Wong <sk...@gmail.com>.
> On 2010-09-20 18:14:21, Zheng Shao wrote:
> >
Thanks for taking the time to review it! See my comments below.
> On 2010-09-20 18:14:21, Zheng Shao wrote:
> > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java, line 179
> > <http://review.cloudera.org/r/828/diff/3/?file=12162#file12162line179>
> >
> > While this function works for most cases, there is no guarantee that it will work for nested map/array/struct, because toString() is not required to be implemented correctly for Objects in hive.
> >
> > The preferred way would be to use ObjectInspectorUtils/ObjectInspectorConvertors to copy/convert <Object, ObjectInspector> to "Standard Object", and then convert to JDBC objects.
> >
It is a good point regarding toString. I didn't try nested container types; I'm trying nested map for the first time now and it doesn't work. Will fix. Will see how ObjectInspector* can help.
> On 2010-09-20 18:14:21, Zheng Shao wrote:
> > trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java, line 54
> > <http://review.cloudera.org/r/828/diff/3/?file=12173#file12173line54>
> >
> > Can we change the name to serializeField (here and in LazySimpleSerDe)?
> >
OK.
- Steven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/828/#review1273
-----------------------------------------------------------
On 2010-09-20 12:55:10, Steven Wong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/828/
> -----------------------------------------------------------
>
> (Updated 2010-09-20 12:55:10)
>
>
> Review request for Hive Developers.
>
>
> Summary
> -------
>
> HIVE-1606 is also fixed as a side effect.
>
>
> This addresses bug HIVE-1378.
> http://issues.apache.org/jira/browse/HIVE-1378
>
>
> Diffs
> -----
>
> trunk/build.xml 997983
> trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 997983
> trunk/conf/hive-default.xml 997983
> trunk/data/files/datatypes.txt PRE-CREATION
> trunk/data/scripts/input20_script 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 997983
> trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 997983
> trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 997983
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 997983
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 997983
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 997983
> trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 997983
> trunk/ql/src/test/results/compiler/plan/input20.q.xml 997983
> trunk/ql/src/test/results/compiler/plan/input4.q.xml 997983
> trunk/ql/src/test/results/compiler/plan/input5.q.xml 997983
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION
> trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 997983
>
> Diff: http://review.cloudera.org/r/828/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven
>
>