You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 14:18:38 UTC
[GitHub] [spark] nikriek opened a new pull request #31899: [WIP][SPARK-34525] Update Spark Create Table DDL to reflect alternative key value notation for
nikriek opened a new pull request #31899:
URL: https://github.com/apache/spark/pull/31899
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This change updates the documentation for [Create Table DDL Datasource](https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-table-datasource.html), [Create Table DDL Hiveformat](https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-table-hiveformat.html) and [Create Table DDL Like](https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-table-like.html) to reflect the alternative notation of key-value pairs `[ ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ]`. I decided against just highlighting the optional `=` vs space for better readability.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Documentation update to reflect alternative notation
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the previous documentation did not account for the alternative notation of key value pairs.
Example for [Create Table DDL Datasource](https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-table-datasource.html)
Previous:
```sql
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
[ OPTIONS ( key1=val1, key2=val2, ... ) ]
[ PARTITIONED BY ( col_name1, col_name2, ... ) ]
[ CLUSTERED BY ( col_name3, col_name4, ... )
[ SORTED BY ( col_name [ ASC | DESC ], ... ) ]
INTO num_buckets BUCKETS ]
[ LOCATION path ]
[ COMMENT table_comment ]
[ TBLPROPERTIES ( key1=val1, key2=val2, ... ) ]
[ AS select_statement ]
```
Now:
```sql
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
[ OPTIONS [ ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ] ]
[ PARTITIONED BY ( col_name1, col_name2, ... ) ]
[ CLUSTERED BY ( col_name3, col_name4, ... )
[ SORTED BY ( col_name [ ASC | DESC ], ... ) ]
INTO num_buckets BUCKETS ]
[ LOCATION path ]
[ COMMENT table_comment ]
[ TBLPROPERTIES [ ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ] ]
[ AS select_statement ]
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No tests because it was just a documentation change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810190453
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41296/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803504740
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-802893284
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-809026184
Ah, could you update the PR description, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810158112
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136714/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r604035533
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -219,9 +219,9 @@ ALTER TABLE table_identifier [ partition_spec ] SET LOCATION 'new_location'
Specifies the partition on which the property has to be set. Note that one can use a typed literal (e.g., date'2019-01-02') in the partition spec.
- **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
+ **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
-* **SERDEPROPERTIES ( key1 = val1, key2 = val2, ... )**
+* **SERDEPROPERTIES ( key1 [=] val1, key2 [=] val2, ... ) **
Review comment:
nit `) **` => `)**` (a unnecessary space?)
##########
File path: docs/sql-ref-syntax-ddl-alter-table.md
##########
@@ -219,9 +219,9 @@ ALTER TABLE table_identifier [ partition_spec ] SET LOCATION 'new_location'
Specifies the partition on which the property has to be set. Note that one can use a typed literal (e.g., date'2019-01-02') in the partition spec.
- **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
+ **Syntax:** `PARTITION ( partition_col_name = partition_col_val [ , ... ] )`
-* **SERDEPROPERTIES ( key1 = val1, key2 = val2, ... )**
+* **SERDEPROPERTIES ( key1 [=] val1, key2 [=] val2, ... ) **
Review comment:
nit `) **` => `)**` (a unnecessary change?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808741872
**[Test build #136597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136597/testReport)** for PR 31899 at commit [`3bf7b60`](https://github.com/apache/spark/commit/3bf7b60937811d18c43eca0a9fe676bab2a94ce0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808743316
**[Test build #136596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136596/testReport)** for PR 31899 at commit [`cc4114e`](https://github.com/apache/spark/commit/cc4114e6ae284c03934010dc9ffafbe9fb07b34e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` : SERDE serde_class [ WITH SERDEPROPERTIES (key1 [=] val1, key2 [=] val2, ...) ]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nikriek commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
nikriek commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-809144833
Done 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808741425
**[Test build #136596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136596/testReport)** for PR 31899 at commit [`cc4114e`](https://github.com/apache/spark/commit/cc4114e6ae284c03934010dc9ffafbe9fb07b34e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808748117
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803508315
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810151106
**[Test build #136714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136714/testReport)** for PR 31899 at commit [`19dd264`](https://github.com/apache/spark/commit/19dd2645fe07526b13ed1a57083be69ba288857c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808749376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810188768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803503349
It seems the other DDL stats have the same syntax, e.g. `ALTER TABLE`. Could you fix them, too, in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803503235
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31899:
URL: https://github.com/apache/spark/pull/31899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810190453
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41296/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808749376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nikriek commented on a change in pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
nikriek commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r599725854
##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -29,14 +29,14 @@ The `CREATE TABLE` statement defines a new table using a Data Source.
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
- [ OPTIONS ( key1=val1, key2=val2, ... ) ]
+ [ OPTIONS ( ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ) ]
Review comment:
Agree, I don't have strong arguments against your version. I would argue that my version is more readable for a documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803508319
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nikriek commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
nikriek commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808741099
> It seems the other DDL stats have the same syntax, e.g. `ALTER TABLE`. Could you fix them, too, in this PR?
Done. I fixed it for any occurrence of `tablePropertyList` in the SqlBase.g4 file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-802893284
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r603646685
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -37,11 +37,11 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
[ ROW FORMAT row_format ]
[ STORED AS file_format ]
[ LOCATION path ]
- [ TBLPROPERTIES ( key1=val1, key2=val2, ... ) ]
+ [ TBLPROPERTIES ( key1 [=] val1, key2 [=] val2, ... ) ]
[ AS select_statement ]
row_format:
- : SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+ : SERDE serde_class [ WITH SERDEPROPERTIES (key1 [=] val1, key2 [=] val2, ...) ]
Review comment:
you accidentally added an extra space in between of `)` and `]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810151106
**[Test build #136714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136714/testReport)** for PR 31899 at commit [`19dd264`](https://github.com/apache/spark/commit/19dd2645fe07526b13ed1a57083be69ba288857c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-898974052
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810157877
**[Test build #136714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136714/testReport)** for PR 31899 at commit [`19dd264`](https://github.com/apache/spark/commit/19dd2645fe07526b13ed1a57083be69ba288857c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` : SERDE serde_class [ WITH SERDEPROPERTIES (key1 [=] val1, key2 [=] val2, ...) ]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803507614
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nikriek commented on a change in pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
nikriek commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r599725854
##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -29,14 +29,14 @@ The `CREATE TABLE` statement defines a new table using a Data Source.
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
- [ OPTIONS ( key1=val1, key2=val2, ... ) ]
+ [ OPTIONS ( ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ) ]
Review comment:
Agree, I don't have strong arguments against your version. I would argue that the my version is more readable for a documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808743362
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808743651
**[Test build #136597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136597/testReport)** for PR 31899 at commit [`3bf7b60`](https://github.com/apache/spark/commit/3bf7b60937811d18c43eca0a9fe676bab2a94ce0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nikriek commented on a change in pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
nikriek commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r602725216
##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -29,14 +29,14 @@ The `CREATE TABLE` statement defines a new table using a Data Source.
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
- [ OPTIONS ( key1=val1, key2=val2, ... ) ]
+ [ OPTIONS ( ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ) ]
Review comment:
I ultimately went with your proposal 👍 My version didn't feel that readable and concise anymore when using it in the various places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808743362
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-833172402
@nikriek Could you resolve the conflict? Also, could you fix the same issue in https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-hive-format.md#L33, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r600134154
##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -29,14 +29,14 @@ The `CREATE TABLE` statement defines a new table using a Data Source.
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
- [ OPTIONS ( key1=val1, key2=val2, ... ) ]
+ [ OPTIONS ( ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ) ]
Review comment:
I am OK either way. As long as we keep these consistent for all the ddl statements, I am fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r598932916
##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -29,14 +29,14 @@ The `CREATE TABLE` statement defines a new table using a Data Source.
CREATE TABLE [ IF NOT EXISTS ] table_identifier
[ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
USING data_source
- [ OPTIONS ( key1=val1, key2=val2, ... ) ]
+ [ OPTIONS ( ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ) ]
Review comment:
I guess we can use `[ ]`to make the `=` optional?
```
[ OPTIONS ( key1 [ = ] val1 [ , ... ] ) ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803503908
**[Test build #136295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136295/testReport)** for PR 31899 at commit [`34690ed`](https://github.com/apache/spark/commit/34690ed5e1cc54834e710031d5acb9483f23a8b8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nikriek commented on a change in pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
nikriek commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r604007789
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -37,11 +37,11 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
[ ROW FORMAT row_format ]
[ STORED AS file_format ]
[ LOCATION path ]
- [ TBLPROPERTIES ( key1=val1, key2=val2, ... ) ]
+ [ TBLPROPERTIES ( key1 [=] val1, key2 [=] val2, ... ) ]
[ AS select_statement ]
row_format:
- : SERDE serde_class [ WITH SERDEPROPERTIES (k1=v1, k2=v2, ... ) ]
+ : SERDE serde_class [ WITH SERDEPROPERTIES (key1 [=] val1, key2 [=] val2, ...) ]
Review comment:
Thanks! I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808741872
**[Test build #136597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136597/testReport)** for PR 31899 at commit [`3bf7b60`](https://github.com/apache/spark/commit/3bf7b60937811d18c43eca0a9fe676bab2a94ce0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803503908
**[Test build #136295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136295/testReport)** for PR 31899 at commit [`34690ed`](https://github.com/apache/spark/commit/34690ed5e1cc54834e710031d5acb9483f23a8b8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803504714
**[Test build #136295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136295/testReport)** for PR 31899 at commit [`34690ed`](https://github.com/apache/spark/commit/34690ed5e1cc54834e710031d5acb9483f23a8b8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808749137
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-809025601
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL and other documentation to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-808741425
**[Test build #136596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136596/testReport)** for PR 31899 at commit [`cc4114e`](https://github.com/apache/spark/commit/cc4114e6ae284c03934010dc9ffafbe9fb07b34e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][SQL][DOCS] Update documentation for various DDLs to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-810158112
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136714/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803508319
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31899:
URL: https://github.com/apache/spark/pull/31899#issuecomment-803504740
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org