[GitHub] [airflow] jedcunningham commented on a change in pull request #15046: Add different modes to sort dag files for parsing

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #15046:
URL: https://github.com/apache/airflow/pull/15046#discussion_r602791196



##########
File path: airflow/configuration.py
##########
@@ -253,6 +253,18 @@ def _validate_config_dependencies(self):
                     + ", ".join(start_method_options)
                 )
 
+        if self.has_option("scheduler", "file_parsing_sort_mode"):
+            list_mode = self.get("scheduler", "file_parsing_sort_mode", fallback="modified_time")

Review comment:
       ```suggestion
               list_mode = self.get("scheduler", "file_parsing_sort_mode")
   ```
   
   We get the fallback for free from `default_airflow.cfg`, no need to duplicate it here.

##########
File path: airflow/utils/dag_processing.py
##########
@@ -1017,25 +1019,50 @@ def prepare_file_path_queue(self):
         # processed recently, wait until the next batch
         file_paths_in_progress = self._processors.keys()
         now = timezone.utcnow()
+
+        # Sort the file paths by the parsing order mode
+        list_mode = conf.get("scheduler", "file_parsing_sort_mode", fallback="modified_time")

Review comment:
       ```suggestion
           list_mode = conf.get("scheduler", "file_parsing_sort_mode")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org