You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/07/26 12:12:33 UTC
[GitHub] [incubator-iotdb] JulianFeinauer commented on a change in pull
request #310: Final steps towards rel.
JulianFeinauer commented on a change in pull request #310: Final steps towards rel.
URL: https://github.com/apache/incubator-iotdb/pull/310#discussion_r307714852
##########
File path: pom.xml
##########
@@ -584,5 +583,78 @@
</plugins>
</build>
</profile>
+ <!-- Make sure the source assembly has the right name (includes "incubating") -->
+ <profile>
+ <id>apache-release</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>source-release-assembly</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <!-- heads up: combine.self in the following is highlighted
+ as an error in Eclipse's xml editor view.
+ Just ignore that.
+ See https://issues.apache.org/jira/browse/MNG-5454 sigh.
+ -->
+ <configuration combine.self="append">
+ <finalName>apache-iotdb-${project.version}-incubating</finalName>
Review comment:
yeah.. therefore I changed the name of the module back to "iotdb-parent" which is more standard : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services