You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2024/05/22 05:38:21 UTC
[PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
reswqa opened a new pull request, #101:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/101
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #101:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/101#discussion_r1609293105
##########
tools/maven/checkstyle.xml:
##########
@@ -224,10 +224,6 @@ This file is based on the checkstyle file of Apache Beam.
<property name="illegalPkgs" value="io.netty"/>
<message key="import.illegal" value="{0}; Use flink-shaded-netty instead."/>
</module>
- <module name="IllegalImport">
- <property name="illegalPkgs" value="com.google.common"/>
Review Comment:
should we put here `org.apache.flink.shaded` to make it failing once flink-shaded is added to import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #101:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/101#issuecomment-2124023352
Thanks for the review! Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #101:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/101#discussion_r1609308618
##########
tools/maven/checkstyle.xml:
##########
@@ -224,10 +224,6 @@ This file is based on the checkstyle file of Apache Beam.
<property name="illegalPkgs" value="io.netty"/>
<message key="import.illegal" value="{0}; Use flink-shaded-netty instead."/>
</module>
- <module name="IllegalImport">
- <property name="illegalPkgs" value="com.google.common"/>
Review Comment:
Yes, make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #101:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/101#discussion_r1609308618
##########
tools/maven/checkstyle.xml:
##########
@@ -224,10 +224,6 @@ This file is based on the checkstyle file of Apache Beam.
<property name="illegalPkgs" value="io.netty"/>
<message key="import.illegal" value="{0}; Use flink-shaded-netty instead."/>
</module>
- <module name="IllegalImport">
- <property name="illegalPkgs" value="com.google.common"/>
Review Comment:
Yes, make sense. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #101:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org