[hadoop] branch trunk updated: HADOOP-9851. dfs -chown does not like "+" plus sign in user name. Contributed by Andras Bokor.

[ay...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ayushsaxena pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new c8ed33c  HADOOP-9851. dfs -chown does not like "+" plus sign in user name. Contributed by Andras Bokor.
c8ed33c is described below

commit c8ed33cd2a4b92618ba2bd7d2cd6cc7961690e44
Author: Ayush Saxena <ay...@apache.org>
AuthorDate: Wed Jun 17 13:55:40 2020 +0530

    HADOOP-9851. dfs -chown does not like "+" plus sign in user name. Contributed by Andras Bokor.
---
 .../src/main/java/org/apache/hadoop/fs/FsShellPermissions.java         | 2 +-
 .../hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShellPermissions.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShellPermissions.java
index 76e379c..1a8a777 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShellPermissions.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShellPermissions.java
@@ -112,7 +112,7 @@ public class FsShellPermissions extends FsCommand {
   
   // used by chown/chgrp
   static private String allowedChars = Shell.WINDOWS ? "[-_./@a-zA-Z0-9 ]" :
-    "[-_./@a-zA-Z0-9]";
+    "[-+_./@a-zA-Z0-9]";
 
   /**
    * Used to change owner and/or group of files 
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
index 6503251..d3920fc 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
@@ -1468,6 +1468,9 @@ public class TestDFSShell {
 
     runCmd(shell, "-chgrp", "hadoop-core@apache.org/100", file);
     confirmOwner(null, "hadoop-core@apache.org/100", fs, path);
+
+    runCmd(shell, "-chown", "MYCOMPANY+user.name:hadoop", file);
+    confirmOwner("MYCOMPANY+user.name", "hadoop", fs, path);
   }
 
   /**


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org