You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "stefanseifert (via GitHub)" <gi...@apache.org> on 2026/02/20 09:20:39 UTC
[PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
stefanseifert opened a new pull request, #67:
URL: https://github.com/apache/sling-parent/pull/67
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on code in PR #67:
URL: https://github.com/apache/sling-parent/pull/67#discussion_r2832643305
##########
sling-parent/pom.xml:
##########
Review Comment:
will do - it's unfortunate that this is not properly managed as maven dependency of the plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #67:
URL: https://github.com/apache/sling-parent/pull/67#issuecomment-3933155721
## [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=67) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=67&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=67&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=67&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=67&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=67&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=67)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on code in PR #67:
URL: https://github.com/apache/sling-parent/pull/67#discussion_r2832632311
##########
sling-parent/pom.xml:
##########
@@ -107,7 +107,7 @@
<properties>
<site.jira.version.id>12313945</site.jira.version.id>
<site.javadoc.exclude />
- <junit5.version>5.14.2</junit5.version>
+ <junit5.version>5.14.3</junit5.version>
Review Comment:
i was a bit hesistant as it's quite new - but at wcm.io i also aldready did this switch without problems (except requiring java 17 for the builds). eclipse has a problem with mixed for unit tests and main code - but that's a problem of eclipse.
so yes, let's go to junit 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert merged PR #67:
URL: https://github.com/apache/sling-parent/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #67:
URL: https://github.com/apache/sling-parent/pull/67#issuecomment-3932635335
## [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=67) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=67&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=67&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=67&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=67&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=67&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=67)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #67:
URL: https://github.com/apache/sling-parent/pull/67#issuecomment-3932617414
## [](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=67) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=67&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-parent&pullRequest=67&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-parent&pullRequest=67&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=67&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-parent&pullRequest=67&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-parent&pullRequest=67)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13122 Update Maven Plugins and Build/Testing Deps to latest versions [sling-parent]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #67:
URL: https://github.com/apache/sling-parent/pull/67#discussion_r2832607253
##########
sling-parent/pom.xml:
##########
Review Comment:
Let's upgrade this as well: https://github.com/palantir/palantir-java-format/releases/tag/2.88.0
##########
sling-parent/pom.xml:
##########
@@ -107,7 +107,7 @@
<properties>
<site.jira.version.id>12313945</site.jira.version.id>
<site.javadoc.exclude />
- <junit5.version>5.14.2</junit5.version>
+ <junit5.version>5.14.3</junit5.version>
Review Comment:
What about using JUnit6 (the new major version is primarily to express that it requires Java 17 which shouldn't be an issue in this context) in sling-bundle-parent: https://docs.junit.org/6.0.2/release-notes.html#v6.0.0, that anyhow already requires that version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org