You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/07 11:59:09 UTC

[GitHub] [iceberg] rymurr commented on pull request #2031: Fix properties for custom catalogs in Flink

rymurr commented on pull request #2031:
URL: https://github.com/apache/iceberg/pull/2031#issuecomment-756073479


   I am not a Flink expert but my reading of the [javadoc](https://github.com/apache/flink/blob/master/flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableFactory.java#L54) is that we could accept everything but it seems like its not recommended. I really like that Flink will throw an error if its configured incorrectly so I would prefer to keep some control over options.
   
   However, I agree that the prefix isn't awesome.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org